Updates README & CONTRIBUTING file #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
boktorbb
approved these changes
Mar 22, 2021
|
✅ DCO Check Passed |
SuZhou-Joe
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 12, 2023
* feat: enable workspace id in basePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless test object id Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move formatUrlWithWorkspaceId to core/public/utils Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add space under license Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 43e91fa)
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Oct 13, 2023
* feat: enable workspace id in basePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless test object id Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move formatUrlWithWorkspaceId to core/public/utils Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add space under license Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 16, 2023
* feat: enable workspace id in basePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless test object id Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move formatUrlWithWorkspaceId to core/public/utils Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add space under license Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 43e91fa)
Hailong-am
pushed a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Oct 17, 2023
…ch-project#212) (opensearch-project#225) * [Workspace]Add workspace id in basePath (opensearch-project#212) * feat: enable workspace id in basePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless test object id Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move formatUrlWithWorkspaceId to core/public/utils Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add space under license Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 43e91fa) * feat: some sync Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: modify import path Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
wanglam
pushed a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Feb 22, 2024
* feat: enable workspace id in basePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless test object id Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move formatUrlWithWorkspaceId to core/public/utils Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add space under license Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 7, 2024
* feat: enable workspace id in basePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless test object id Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move formatUrlWithWorkspaceId to core/public/utils Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add space under license Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 8, 2024
* feat: enable workspace id in basePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless test object id Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move formatUrlWithWorkspaceId to core/public/utils Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add space under license Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 8, 2024
* feat: enable workspace id in basePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless test object id Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move formatUrlWithWorkspaceId to core/public/utils Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add space under license Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
added a commit
that referenced
this pull request
Mar 14, 2024
* [Workspace]Add workspace id in basePath (#212) * feat: enable workspace id in basePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless test object id Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move formatUrlWithWorkspaceId to core/public/utils Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add space under license Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add CHANGELOG Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add feature flag check Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make the pr smaller Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize with a more strict check Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add a unit test case Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: better merge Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: rename the workspaceBasePath to clientBasePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: rename withoutWorkspace to withoutClientBasePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "feat: add feature flag check" This reverts commit 64b3645. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "fix: unit test error" This reverts commit 80bed72. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize comment and test cases description Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 18, 2024
* feat: enable workspace id in basePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless test object id Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move formatUrlWithWorkspaceId to core/public/utils Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add space under license Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
* [Workspace]Add workspace id in basePath (#212) * feat: enable workspace id in basePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless test object id Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move formatUrlWithWorkspaceId to core/public/utils Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add space under license Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add CHANGELOG Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add feature flag check Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make the pr smaller Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize with a more strict check Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add a unit test case Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: better merge Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: rename the workspaceBasePath to clientBasePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: rename withoutWorkspace to withoutClientBasePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "feat: add feature flag check" This reverts commit 64b3645. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "fix: unit test error" This reverts commit 80bed72. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize comment and test cases description Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 3073926) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
SuZhou-Joe
pushed a commit
that referenced
this pull request
Apr 14, 2024
* [Workspace]Add workspace id in basePath (#212) * feat: enable workspace id in basePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless test object id Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move formatUrlWithWorkspaceId to core/public/utils Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: move workspace/utils to core Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimization Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add space under license Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add CHANGELOG Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add feature flag check Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make the pr smaller Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize with a more strict check Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add a unit test case Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: better merge Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: rename the workspaceBasePath to clientBasePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: rename withoutWorkspace to withoutClientBasePath Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "feat: add feature flag check" This reverts commit 64b3645. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Revert "fix: unit test error" This reverts commit 80bed72. Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize comment and test cases description Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 3073926) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihir Soni mihirsoni.123@gmail.com