Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.x] Custom healthcheck with filters (#2232) #2247

Merged
merged 1 commit into from
Sep 7, 2022
Merged

[Backport 1.x] Custom healthcheck with filters (#2232) #2247

merged 1 commit into from
Sep 7, 2022

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Sep 1, 2022

Backport e6bbb40 from #2232

@kavilla
Custom healthcheck with filters (opensearch-project#2232)
537a6c4 
Enable filtering with custom health checks based on node attributes:
```
opensearch.optimizedHealthcheck.filters: {
  attribute_key: "attribute_value",
}
```

Also, fixes issue that expects the response to array when it was a
dictionary.

Issue:
opensearch-project#2214
opensearch-project#2203

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@kavilla
Copy link
Member Author

kavilla commented Sep 1, 2022

Had to manually create this one because of conflicts but will use this PR to backport to the v1 branches.

@ashwin-pc
Copy link
Member

I'm confused how we can add multiple changes to already frozen branches like 1.1 and 1.3. shouldn't this count as a new minor release for each major version? So in this case it will be 1.5? Or are we making this a patch fix so it goes in as 1.1.x etc

@kavilla
Copy link
Member Author

kavilla commented Sep 1, 2022 •
edited
Loading

I'm confused how we can add multiple changes to already frozen branches like 1.1 and 1.3. shouldn't this count as a new minor release for each major version? So in this case it will be 1.5? Or are we making this a patch fix so it goes in as 1.1.x etc

Has it been official that these branches are frozen?

This is more of a bug fix as much as it is a feature, so have included in a patch fix.

@kavilla kavilla merged commit e6abd9e into opensearch-project:1.x Sep 7, 2022
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 7, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2022
@kavilla @github-actions
Custom healthcheck with filters (#2232) (#2247)
b8bedf5 
Enable filtering with custom health checks based on node attributes:
```
opensearch.optimizedHealthcheck.filters: {
  attribute_key: "attribute_value",
}
```

Also, fixes issue that expects the response to array when it was a
dictionary.

Issue:
#2214
#2203

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e6abd9e)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 7, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2022
@kavilla @github-actions
Custom healthcheck with filters (#2232) (#2247)
a578e05 
Enable filtering with custom health checks based on node attributes:
```
opensearch.optimizedHealthcheck.filters: {
  attribute_key: "attribute_value",
}
```

Also, fixes issue that expects the response to array when it was a
dictionary.

Issue:
#2214
#2203

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e6abd9e)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 7, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2022
@kavilla @github-actions
Custom healthcheck with filters (#2232) (#2247)
c87020f 
Enable filtering with custom health checks based on node attributes:
```
opensearch.optimizedHealthcheck.filters: {
  attribute_key: "attribute_value",
}
```

Also, fixes issue that expects the response to array when it was a
dictionary.

Issue:
#2214
#2203

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e6abd9e)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 7, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 7, 2022
@kavilla @github-actions
Custom healthcheck with filters (#2232) (#2247)
5a8ec70 
Enable filtering with custom health checks based on node attributes:
```
opensearch.optimizedHealthcheck.filters: {
  attribute_key: "attribute_value",
}
```

Also, fixes issue that expects the response to array when it was a
dictionary.

Issue:
#2214
#2203

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e6abd9e)
ananzh pushed a commit that referenced this pull request Sep 8, 2022
@opensearch-trigger-bot @kavilla
Custom healthcheck with filters (#2232) (#2247) (#2287)
450a674 
Enable filtering with custom health checks based on node attributes:
```
opensearch.optimizedHealthcheck.filters: {
  attribute_key: "attribute_value",
}
```

Also, fixes issue that expects the response to array when it was a
dictionary.

Issue:
#2214
#2203

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e6abd9e)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
ananzh pushed a commit that referenced this pull request Sep 8, 2022
@opensearch-trigger-bot @kavilla
Custom healthcheck with filters (#2232) (#2247) (#2288)
1186804 
Enable filtering with custom health checks based on node attributes:
```
opensearch.optimizedHealthcheck.filters: {
  attribute_key: "attribute_value",
}
```

Also, fixes issue that expects the response to array when it was a
dictionary.

Issue:
#2214
#2203

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e6abd9e)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
ananzh pushed a commit that referenced this pull request Sep 8, 2022
@opensearch-trigger-bot @kavilla
Custom healthcheck with filters (#2232) (#2247) (#2289)
0694107 
Enable filtering with custom health checks based on node attributes:
```
opensearch.optimizedHealthcheck.filters: {
  attribute_key: "attribute_value",
}
```

Also, fixes issue that expects the response to array when it was a
dictionary.

Issue:
#2214
#2203

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e6abd9e)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
ananzh pushed a commit that referenced this pull request Sep 8, 2022
@opensearch-trigger-bot @kavilla
Custom healthcheck with filters (#2232) (#2247) (#2286)
77393de 
Enable filtering with custom health checks based on node attributes:
```
opensearch.optimizedHealthcheck.filters: {
  attribute_key: "attribute_value",
}
```

Also, fixes issue that expects the response to array when it was a
dictionary.

Issue:
#2214
#2203

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e6abd9e)

Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
@ananzh ananzh added the v1.3.6 label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristenTian kristenTian kristenTian approved these changes

@Flyingliuhub Flyingliuhub Flyingliuhub approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

Assignees
No one assigned
Labels
backport 1.3 v1.3.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kavilla @ashwin-pc @Flyingliuhub @kristenTian @ananzh