[Backport 2.x] [D&D] Adds Bar line and Area charts to Wizard #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Working histogram Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds histogram options Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds line chart Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds area chart Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * updates nav sizes Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * adds resizeable container to right nav Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Misc fixes Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Adds chart switcher test Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Github comment feedback Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> * Updates copy Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 77af7f9)
ananzh
approved these changes
Sep 8, 2022
noCharger
approved these changes
Sep 8, 2022
Codecov Report
@@ Coverage Diff @@
## 2.x #2291 +/- ##
======================================
Coverage ? 66.55%
======================================
Files ? 3169
Lines ? 60313
Branches ? 9182
======================================
Hits ? 40141
Misses ? 17979
Partials ? 2193 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
seraphjiang
pushed a commit
to seraphjiang/OpenSearch-Dashboards
that referenced
this pull request
Oct 17, 2022
… (opensearch-project#2291) Description * Adds Bar line and Area charts to Wizard * Adds resizable right nav to Wizard * E2E tests for bar chart and chart switching Issues Resolved: opensearch-project#1616 opensearch-project#1617 opensearch-project#1618 Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Ashwin Pc <ashwinpc@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 77af7f9 from #2266