Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.2] [BUG] fix healthcheck logic to expect object and return ids #2302

Merged
merged 1 commit into from
Sep 8, 2022
Merged

[Backport 1.2] [BUG] fix healthcheck logic to expect object and return ids #2302

merged 1 commit into from
Sep 8, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e10ba34 from #2300

@kavilla @github-actions
[BUG] fix healthcheck logic to expect object and return ids (#2277) (#…
d423fdd 
…2300)

Original implementation incorrectly assumed the return list of
nodes was an object array.
This PR:
#2232

Addressed the return but didn't catch the nodes.find in the return
which is a function for an array.

Also, refactors to return a list of node_ids because the original
implementation indicated that it should but it can return node ids
but it never did. It only returned `null` or `_local`, the problem
with this approach is that it doesn't expect valid node version
with different DIs or filter out nodes when we pass `null` as the node
ID for the node info call because it was fan out the request to all
nodes.

Now this function will return `_local` if all the nodes share the
same cluster_id using a greedy approach since we can assume it is
all the same version.

Will return node ids, if the cluster_id are different so it will
pass a CSV to the node info call and return the info for those nodes.
And null if no cluster_id is present, ie, fan out the response.

Original issue:
#2203

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
(cherry picked from commit e10ba34)
@kavilla kavilla changed the title [Backport 1.2] [Backport 1.x] [BUG] fix healthcheck logic to expect object and return ids [Backport 1.2] [BUG] fix healthcheck logic to expect object and return ids Sep 8, 2022
@kavilla kavilla merged commit d0c549d into 1.2 Sep 8, 2022
@kavilla kavilla deleted the backport/backport-2300-to-1.2 branch November 23, 2022 09:09
@joshuarrrr joshuarrrr added the not in release PRs backported to already shipped releases with no future release planned label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@Flyingliuhub Flyingliuhub Flyingliuhub approved these changes

Assignees
No one assigned
Labels
not in release PRs backported to already shipped releases with no future release planned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kavilla @Flyingliuhub @joshuarrrr