add path ignore for markdown files #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2312 +/- ##
=======================================
Coverage 66.55% 66.55%
=======================================
Files 3169 3169
Lines 60313 60313
Branches 9182 9182
=======================================
Hits 40141 40141
Misses 17979 17979
Partials 2193 2193 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
abbyhu2000
force-pushed
the
skip_workflow_for_markdown_change
branch
from
0fcd7ac
to
982e239
Compare
zhongnansu
reviewed
Sep 13, 2022
There was a problem hiding this comment.
- Should we also ignore
.asciidocfile changes? - How do we keep doc website updated with doc in codebase? Do we have any workflows that auto update our doc website using any of the
.mdfiles in codebase? or any ongoing documentation related projects will do that? If that's the case, CI will help to make sure doc is correct and always updated.
cc @kavilla since you created the issue.
the current doc site https://opensearch.org/docs/latest/dashboards/index/ actually only hosts manually updates from the doc team in the doc repo. unofficially we use https://cptnb.github.io/opensearch-dashboards-dev-docs/ to host dev docs (docs from this repo), which I believe @CPTNB has a fork of the repo that has a workflow that publishes dev docs there. for the .asciidoc, it's probably good feature to add the future. |
ashwin-pc
approved these changes
Sep 13, 2022
kavilla
approved these changes
Sep 14, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 14, 2022
To save resources and job runners, some PRs do not need to run the full test suite. For PRs and pushes with markdown changes only, the build and test workflow will be skipped. (Linter test should be okay to skipped since it will automatically run with every commit). For PRs and pushes with markdown changes along with other changes, the build and test workflow will not be skipped. Issue Resolved: #1214 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit ab99eac)
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this pull request
Sep 14, 2022
To save resources and job runners, some PRs do not need to run the full test suite. For PRs and pushes with markdown changes only, the build and test workflow will be skipped. (Linter test should be okay to skipped since it will automatically run with every commit). For PRs and pushes with markdown changes along with other changes, the build and test workflow will not be skipped. Issue Resolved: opensearch-project#1214 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
kavilla
pushed a commit
that referenced
this pull request
Sep 15, 2022
To save resources and job runners, some PRs do not need to run the full test suite. For PRs and pushes with markdown changes only, the build and test workflow will be skipped. (Linter test should be okay to skipped since it will automatically run with every commit). For PRs and pushes with markdown changes along with other changes, the build and test workflow will not be skipped. Issue Resolved: #1214 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit ab99eac) Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this pull request
Dec 16, 2022
To save resources and job runners, some PRs do not need to run the full test suite. For PRs and pushes with markdown changes only, the build and test workflow will be skipped. (Linter test should be okay to skipped since it will automatically run with every commit). For PRs and pushes with markdown changes along with other changes, the build and test workflow will not be skipped. Issue Resolved: opensearch-project#1214 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: abbyhu2000 abigailhu2000@gmail.com
Description
To save resources and job runners, some PRs do not need to run the full test suite. For PRs and pushes with markdown changes only, the build and test workflow will be skipped. (Linter test should be okay to skipped since it will automatically run with every commit). For PRs and pushes with markdown changes along with other changes, the build and test workflow will not be skipped.
Issues Resolved
resolves #1214
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr