-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI][Tests] Add BWC tests for 2.4.0 #2393
Conversation
Do we mean bwc tests for version 2.4.0? (since it's for backward compatibility) |
@@ -186,7 +186,7 @@ jobs: | |||
working-directory: ./artifacts | |||
strategy: | |||
matrix: | |||
version: [ osd-2.0.0, osd-2.1.0, osd-2.2.0 ] | |||
version: [ osd-2.0.0, osd-2.1.0, osd-2.2.0, osd-2.3.0 ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to include 1.3.2? #2284
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is going into main (v2.4.0) for the future changes to be backward compatible with 2.3.0. I see in #2284 1.3.2 was restored into 2.x branch. Do you mean we need to restore 1.3.2 into main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question yall. For main
, it is on version 3.0.0. Via BWC tests we were actually able to realize it is not compatible to migrate directly from 1.x
to 3.x
which is set by OpenSearch reading which version our indices are from and rejecting the migration. So this helps us keep track and ping doc owners to ensure to note this.
tl;dr: 1.3.2 can't be added to main. Users will have to migrate from 1.x to 2.x to 3.x
9240c7a
to
fd6cd69
Compare
Good catch! |
fd6cd69
to
9a2fd45
Compare
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
9a2fd45
to
8a5b31b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Mana.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2393-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 08d05047d125afa7a6f5426de400b1a8b9be62c5
# Push it to GitHub
git push --set-upstream origin backport/backport-2393-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> (cherry picked from commit 08d0504)
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> (cherry picked from commit 08d0504) Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
Backport to this PR #2393 Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Signed-off-by: Manasvini B Suryanarayana manasvis@amazon.com
Description
Test data generated with:
yarn test:bwc -o https://artifacts.opensearch.org/releases/bundle/opensearch/2.3.0/opensearch-2.3.0-linux-x64.tar.gz -d https://artifacts.opensearch.org/releases/bundle/opensearch-dashboards/2.3.0/opensearch-dashboards-2.3.0-linux-x64.tar.gz -g true
yarn test:bwc -o https://artifacts.opensearch.org/releases/bundle/opensearch/2.3.0/opensearch-2.3.0-linux-x64.tar.gz -d https://artifacts.opensearch.org/releases/bundle/opensearch-dashboards/2.3.0/opensearch-dashboards-2.3.0-linux-x64.tar.gz -g true -s true
Issues Resolved
#2230
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr