-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sample config of multi data source to yml template. #2428
Add sample config of multi data source to yml template. #2428
Conversation
|
||
# Set the value of this setting to true to enables the experimental multiple data source | ||
# support feature. Use with caution. | ||
#data_source.enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: For consistency, can we add a space between the comment delimiter and the config key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the convention in this file is:
- for comments/explanations, put a space between comment content and comment delimiter
#
- for sample config key/settings, no space between config key and comment delimiter
#
So that it is easy for people to differentiate comment/explanations vs. sample configs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
# Set the value of these settings to custermize crypto materials to encryption saved credentials | ||
# in data sources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can/should we link to documentation for these settings? It's not at all clear from this file alone what valid values here might look like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see other settings has reference to document in the template. there is another PR which provides document of all settings in README #2448
6371619
Codecov Report
@@ Coverage Diff @@
## main #2428 +/- ##
==========================================
+ Coverage 66.74% 66.75% +0.01%
==========================================
Files 3194 3200 +6
Lines 60803 60886 +83
Branches 9238 9250 +12
==========================================
+ Hits 40583 40646 +63
- Misses 18011 18029 +18
- Partials 2209 2211 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm, we might also add audit configs after it's complete
6371619
to
9281d51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see @ashwin-pc and @joshuarrrr comments have been resolved.
LGTM
@zengyan-amazon looks like your original commit is missing a signoff, the rest LGTM |
Signed-off-by: Yan Zeng <zengyan@amazon.com>
d646561
to
8461543
Compare
fixed sign off commit |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2428-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 60efd3bacab8a092bacb5842854d41bf48423fdc
# Push it to GitHub
git push --set-upstream origin backport/backport-2428-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…earch-project#2428) Signed-off-by: Yan Zeng <zengyan@amazon.com> Signed-off-by: Yan Zeng <zengyan@amazon.com> (cherry picked from commit 60efd3b)
…earch-project#2428) Signed-off-by: Yan Zeng <zengyan@amazon.com> Signed-off-by: Yan Zeng <zengyan@amazon.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Description
Add sample config of multi data source to yml template.
Issues Resolved
#2427
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr