[PURIFY][BUILD] Remove isOss flag and defaults to oss build #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
|
✅ DCO Check Passed a1a4bd3 |
mihirsoni
commented
Apr 3, 2021
| @@ -74,7 +74,7 @@ export const BuildPackages: Task = { | |||
| await buildProductionProjects({ | |||
| opensearchDashboardsRoot: config.resolveFromRepo(), | |||
| buildRoot: build.resolvePath(), | |||
| onlyOSS: build.isOss(), | |||
| onlyOSS: true, | |||
There was a problem hiding this comment.
Note: Remove this from other packages.
seraphjiang
reviewed
Apr 3, 2021
| @@ -49,12 +49,6 @@ export const CreatePackageJson: Task = { | |||
| dependencies: pkg.dependencies, | |||
| }; | |||
|
|
|||
| if (build.isOss()) { | |||
| newPkg.workspaces.packages = newPkg.workspaces.packages.filter( | |||
There was a problem hiding this comment.
seems applied for oss, why not keep this.
There was a problem hiding this comment.
There is no x-pack workspace anymore so irrelevant.
ananzh
approved these changes
Apr 3, 2021
4 tasks
wanglam
added a commit
to wanglam/OpenSearch-Dashboards
that referenced
this pull request
Feb 21, 2024
* fix: permissions missed after workspace update Signed-off-by: Lin Wang <wonglam@amazon.com> * remove not used imports Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves] Remove
isOSSossand-no-ssflag from the build distribution code. This still has some hard coded flag, which needs to be removed from other packages, i'll create follow up PRs for the same.To test this :
Issues Resolved
[List any issues this PR will resolve] #26
Check List
Signed-off-by: Mihir Soni mihirsoni.123@gmail.com