-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MD] UX refactor for datasource create page #2501
[MD] UX refactor for datasource create page #2501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- fix Build CI.
- add change log
- update snapshot tests?
src/plugins/data_source_management/public/components/text_content/text_content.ts
Outdated
Show resolved
Hide resolved
Do we need to update the snapshot as well? |
...blic/components/create_data_source_wizard/components/create_form/create_data_source_form.tsx
Outdated
Show resolved
Hide resolved
faeaa83
to
8dd3132
Compare
96e3bb4
to
c0a2537
Compare
Signed-off-by: Yibo Wang <yibow@amazon.com>
Signed-off-by: Yibo Wang <yibow@amazon.com>
Signed-off-by: Yibo Wang <yibow@amazon.com>
Signed-off-by: Yibo Wang <yibow@amazon.com>
b615245
to
89d2b49
Compare
Signed-off-by: Yibo Wang <yibow@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #2501 +/- ##
=======================================
Coverage 66.73% 66.73%
=======================================
Files 3203 3204 +1
Lines 60978 60988 +10
Branches 9274 9274
=======================================
+ Hits 40692 40702 +10
Misses 18067 18067
Partials 2219 2219
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ccf9e03
to
03002ed
Compare
03002ed
to
56d4bf8
Compare
...nagement/public/management_app/compoenent/experimental_callout/experimental_callout.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ashwin-pc for giving me some constructive feedback and suggestions. Will address all unit test issues in my next PR and I will link this PR as a reference~ |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2501-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9b56ff50327154cd531fcd4479ab2fc3798cf86b
# Push it to GitHub
git push --set-upstream origin backport/backport-2501-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
* UX refactor for datasource create page Signed-off-by: Yibo Wang <yibow@amazon.com> * address comments&add CHANGLOG Signed-off-by: Yibo Wang <yibow@amazon.com> * Apply callout in all ds pages & update endpoint field placeholder text Signed-off-by: Yibo Wang <yibow@amazon.com> * add documentation links Signed-off-by: Yibo Wang <yibow@amazon.com> * update snapshot test and snapshots Signed-off-by: Yibo Wang <yibow@amazon.com> * Update CHANGELOG.md&.lycheeexclude Signed-off-by: Yibo Wang <yibow@amazon.com> * Update UT Signed-off-by: Yibo Wang <yibow@amazon.com> Signed-off-by: Yibo Wang <yibow@amazon.com> (cherry picked from commit 9b56ff5)
* UX refactor for datasource create page Signed-off-by: Yibo Wang <yibow@amazon.com> * address comments&add CHANGLOG Signed-off-by: Yibo Wang <yibow@amazon.com> * Apply callout in all ds pages & update endpoint field placeholder text Signed-off-by: Yibo Wang <yibow@amazon.com> * add documentation links Signed-off-by: Yibo Wang <yibow@amazon.com> * update snapshot test and snapshots Signed-off-by: Yibo Wang <yibow@amazon.com> * Update CHANGELOG.md&.lycheeexclude Signed-off-by: Yibo Wang <yibow@amazon.com> * Update UT Signed-off-by: Yibo Wang <yibow@amazon.com> Signed-off-by: Yibo Wang <yibow@amazon.com> (cherry picked from commit 9b56ff5)
* UX refactor for datasource create page Signed-off-by: Yibo Wang <yibow@amazon.com> * address comments&add CHANGLOG Signed-off-by: Yibo Wang <yibow@amazon.com> * Apply callout in all ds pages & update endpoint field placeholder text Signed-off-by: Yibo Wang <yibow@amazon.com> * add documentation links Signed-off-by: Yibo Wang <yibow@amazon.com> * update snapshot test and snapshots Signed-off-by: Yibo Wang <yibow@amazon.com> * Update CHANGELOG.md&.lycheeexclude Signed-off-by: Yibo Wang <yibow@amazon.com> * Update UT Signed-off-by: Yibo Wang <yibow@amazon.com> Signed-off-by: Yibo Wang <yibow@amazon.com> (cherry picked from commit 9b56ff5) Co-authored-by: Yibo Wang <109543558+yibow98@users.noreply.github.com>
…opensearch-project#2559) * UX refactor for datasource create page Signed-off-by: Yibo Wang <yibow@amazon.com> * address comments&add CHANGLOG Signed-off-by: Yibo Wang <yibow@amazon.com> * Apply callout in all ds pages & update endpoint field placeholder text Signed-off-by: Yibo Wang <yibow@amazon.com> * add documentation links Signed-off-by: Yibo Wang <yibow@amazon.com> * update snapshot test and snapshots Signed-off-by: Yibo Wang <yibow@amazon.com> * Update CHANGELOG.md&.lycheeexclude Signed-off-by: Yibo Wang <yibow@amazon.com> * Update UT Signed-off-by: Yibo Wang <yibow@amazon.com> Signed-off-by: Yibo Wang <yibow@amazon.com> (cherry picked from commit 9b56ff5) Co-authored-by: Yibo Wang <109543558+yibow98@users.noreply.github.com>
* UX refactor for datasource create page Signed-off-by: Yibo Wang <yibow@amazon.com> * address comments&add CHANGLOG Signed-off-by: Yibo Wang <yibow@amazon.com> * Apply callout in all ds pages & update endpoint field placeholder text Signed-off-by: Yibo Wang <yibow@amazon.com> * add documentation links Signed-off-by: Yibo Wang <yibow@amazon.com> * update snapshot test and snapshots Signed-off-by: Yibo Wang <yibow@amazon.com> * Update CHANGELOG.md&.lycheeexclude Signed-off-by: Yibo Wang <yibow@amazon.com> * Update UT Signed-off-by: Yibo Wang <yibow@amazon.com> Signed-off-by: Yibo Wang <yibow@amazon.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Signed-off-by: Yibo Wang yibow@amazon.com
Description
UX refactor for datasource create page
Issues Resolved
opensearch-project/ux#19
opensearch-project/ux#23
opensearch-project/ux#24
opensearch-project/ux#25
opensearch-project/ux#26
opensearch-project/ux#29
#2434
#2439
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr