Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MD] UX refactor for datasource create page #2501

Merged
merged 13 commits into from
Oct 11, 2022

Conversation

yibow98
Copy link
Contributor

@yibow98 yibow98 commented Oct 4, 2022

Signed-off-by: Yibo Wang yibow@amazon.com

Description

UX refactor for datasource create page
Screen Shot 2022-10-04 at 1 31 53 PM

Issues Resolved

opensearch-project/ux#19
opensearch-project/ux#23
opensearch-project/ux#24
opensearch-project/ux#25
opensearch-project/ux#26
opensearch-project/ux#29
#2434
#2439

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@yibow98 yibow98 requested a review from a team as a code owner October 4, 2022 20:37
@yibow98 yibow98 self-assigned this Oct 4, 2022
@yibow98 yibow98 added multiple datasource multiple datasource project ux / ui Improvements or additions to user experience, flows, components, UI elements v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 4, 2022
@yibow98 yibow98 changed the title UX refactor for datasource create page [MD] UX refactor for datasource create page Oct 4, 2022
Copy link
Member

@zhongnansu zhongnansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fix Build CI.
  • add change log
  • update snapshot tests?

src/plugins/data_source_management/public/types.ts Outdated Show resolved Hide resolved
@noCharger
Copy link
Contributor

Do we need to update the snapshot as well?

Signed-off-by: Yibo Wang <yibow@amazon.com>
Signed-off-by: Yibo Wang <yibow@amazon.com>
Signed-off-by: Yibo Wang <yibow@amazon.com>
@yibow98 yibow98 force-pushed the new-ux-ds-creation branch 2 times, most recently from b615245 to 89d2b49 Compare October 6, 2022 20:59
Signed-off-by: Yibo Wang <yibow@amazon.com>
@yibow98 yibow98 marked this pull request as ready for review October 6, 2022 23:33
@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Merging #2501 (858ea59) into main (7777749) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2501   +/-   ##
=======================================
  Coverage   66.73%   66.73%           
=======================================
  Files        3203     3204    +1     
  Lines       60978    60988   +10     
  Branches     9274     9274           
=======================================
+ Hits        40692    40702   +10     
  Misses      18067    18067           
  Partials     2219     2219           
Impacted Files Coverage Δ
src/core/public/doc_links/doc_links_service.ts 100.00% <ø> (ø)
...components/create_form/create_data_source_form.tsx 83.60% <100.00%> (+0.27%) ⬆️
...te_data_source_wizard/components/header/header.tsx 100.00% <100.00%> (ø)
...ent/public/components/text_content/text_content.ts 100.00% <100.00%> (ø)
...nent/experimental_callout/experimental_callout.tsx 100.00% <100.00%> (ø)
...ared/static/forms/hook_form_lib/hooks/use_field.ts 65.70% <0.00%> (-0.97%) ⬇️
...ic/application/models/sense_editor/sense_editor.ts 64.00% <0.00%> (-0.89%) ⬇️
packages/osd-optimizer/src/node/cache.ts 52.77% <0.00%> (+2.77%) ⬆️
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 87.75% <0.00%> (+4.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Yibo Wang <yibow@amazon.com>
kristenTian
kristenTian previously approved these changes Oct 10, 2022
ashwin-pc
ashwin-pc previously approved these changes Oct 11, 2022
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yibow98 and I discussed offline and agreed that this and other unit tests will be addressed in a follow up PR. @yibow98 please link this PR to that so that it is easier to discover those changes in future.

@yibow98
Copy link
Contributor Author

yibow98 commented Oct 11, 2022

@yibow98 and I discussed offline and agreed that this and other unit tests will be addressed in a follow up PR. @yibow98 please link this PR to that so that it is easier to discover those changes in future.

Thanks @ashwin-pc for giving me some constructive feedback and suggestions. Will address all unit test issues in my next PR and I will link this PR as a reference~

@yibow98 yibow98 dismissed stale reviews from ashwin-pc and kristenTian via 18eef6d October 11, 2022 00:50
ashwin-pc
ashwin-pc previously approved these changes Oct 11, 2022
@kristenTian kristenTian merged commit 9b56ff5 into opensearch-project:main Oct 11, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2501-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9b56ff50327154cd531fcd4479ab2fc3798cf86b
# Push it to GitHub
git push --set-upstream origin backport/backport-2501-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2501-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 12, 2022
* UX refactor for datasource create page

Signed-off-by: Yibo Wang <yibow@amazon.com>

* address comments&add CHANGLOG

Signed-off-by: Yibo Wang <yibow@amazon.com>

* Apply callout in all ds pages & update endpoint field placeholder text

Signed-off-by: Yibo Wang <yibow@amazon.com>

* add documentation links

Signed-off-by: Yibo Wang <yibow@amazon.com>

* update snapshot test and snapshots

Signed-off-by: Yibo Wang <yibow@amazon.com>

* Update CHANGELOG.md&.lycheeexclude

Signed-off-by: Yibo Wang <yibow@amazon.com>

* Update UT

Signed-off-by: Yibo Wang <yibow@amazon.com>

Signed-off-by: Yibo Wang <yibow@amazon.com>
(cherry picked from commit 9b56ff5)
kristenTian pushed a commit that referenced this pull request Oct 12, 2022
* UX refactor for datasource create page

Signed-off-by: Yibo Wang <yibow@amazon.com>

* address comments&add CHANGLOG

Signed-off-by: Yibo Wang <yibow@amazon.com>

* Apply callout in all ds pages & update endpoint field placeholder text

Signed-off-by: Yibo Wang <yibow@amazon.com>

* add documentation links

Signed-off-by: Yibo Wang <yibow@amazon.com>

* update snapshot test and snapshots

Signed-off-by: Yibo Wang <yibow@amazon.com>

* Update CHANGELOG.md&.lycheeexclude

Signed-off-by: Yibo Wang <yibow@amazon.com>

* Update UT

Signed-off-by: Yibo Wang <yibow@amazon.com>

Signed-off-by: Yibo Wang <yibow@amazon.com>
(cherry picked from commit 9b56ff5)
kristenTian pushed a commit that referenced this pull request Oct 12, 2022
* UX refactor for datasource create page

Signed-off-by: Yibo Wang <yibow@amazon.com>

* address comments&add CHANGLOG

Signed-off-by: Yibo Wang <yibow@amazon.com>

* Apply callout in all ds pages & update endpoint field placeholder text

Signed-off-by: Yibo Wang <yibow@amazon.com>

* add documentation links

Signed-off-by: Yibo Wang <yibow@amazon.com>

* update snapshot test and snapshots

Signed-off-by: Yibo Wang <yibow@amazon.com>

* Update CHANGELOG.md&.lycheeexclude

Signed-off-by: Yibo Wang <yibow@amazon.com>

* Update UT

Signed-off-by: Yibo Wang <yibow@amazon.com>

Signed-off-by: Yibo Wang <yibow@amazon.com>
(cherry picked from commit 9b56ff5)

Co-authored-by: Yibo Wang <109543558+yibow98@users.noreply.github.com>
@AMoo-Miki AMoo-Miki added the enhancement New feature or request label Nov 5, 2022
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Dec 1, 2022
…opensearch-project#2559)

* UX refactor for datasource create page

Signed-off-by: Yibo Wang <yibow@amazon.com>

* address comments&add CHANGLOG

Signed-off-by: Yibo Wang <yibow@amazon.com>

* Apply callout in all ds pages & update endpoint field placeholder text

Signed-off-by: Yibo Wang <yibow@amazon.com>

* add documentation links

Signed-off-by: Yibo Wang <yibow@amazon.com>

* update snapshot test and snapshots

Signed-off-by: Yibo Wang <yibow@amazon.com>

* Update CHANGELOG.md&.lycheeexclude

Signed-off-by: Yibo Wang <yibow@amazon.com>

* Update UT

Signed-off-by: Yibo Wang <yibow@amazon.com>

Signed-off-by: Yibo Wang <yibow@amazon.com>
(cherry picked from commit 9b56ff5)

Co-authored-by: Yibo Wang <109543558+yibow98@users.noreply.github.com>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
* UX refactor for datasource create page

Signed-off-by: Yibo Wang <yibow@amazon.com>

* address comments&add CHANGLOG

Signed-off-by: Yibo Wang <yibow@amazon.com>

* Apply callout in all ds pages & update endpoint field placeholder text

Signed-off-by: Yibo Wang <yibow@amazon.com>

* add documentation links

Signed-off-by: Yibo Wang <yibow@amazon.com>

* update snapshot test and snapshots

Signed-off-by: Yibo Wang <yibow@amazon.com>

* Update CHANGELOG.md&.lycheeexclude

Signed-off-by: Yibo Wang <yibow@amazon.com>

* Update UT

Signed-off-by: Yibo Wang <yibow@amazon.com>

Signed-off-by: Yibo Wang <yibow@amazon.com>
Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request multiple datasource multiple datasource project ux / ui Improvements or additions to user experience, flows, components, UI elements v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.