-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MD] Adding unit test coverage for Update data source management #2567
Conversation
Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #2567 +/- ##
==========================================
+ Coverage 66.72% 66.81% +0.09%
==========================================
Files 3203 3207 +4
Lines 60940 61136 +196
Branches 9275 9313 +38
==========================================
+ Hits 40662 40851 +189
+ Misses 18058 18055 -3
- Partials 2220 2230 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
Signed-off-by: mpabba3003 <amazonmanideep@gmail.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2567-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 115105a3c945dae4c2218caaeacaa854b2789afa
# Push it to GitHub
git push --set-upstream origin backport/backport-2567-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2567-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 115105a3c945dae4c2218caaeacaa854b2789afa
# Push it to GitHub
git push --set-upstream origin backport/backport-2567-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
* adding unit test cases for edit data source page Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * lint mock file Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating snapshot Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating CHANGELOG.MD Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating CHANGELOG.MD Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating CHANGELOG.MD Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> (cherry picked from commit 115105a)
* adding unit test cases for edit data source page Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * lint mock file Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating snapshot Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating CHANGELOG.MD Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating CHANGELOG.MD Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating CHANGELOG.MD Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> (cherry picked from commit 115105a)
* adding unit test cases for edit data source page Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * lint mock file Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating snapshot Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating CHANGELOG.MD Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating CHANGELOG.MD Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating CHANGELOG.MD Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> (cherry picked from commit 115105a)
…nsearch-project#2567) * adding unit test cases for edit data source page Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * lint mock file Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating snapshot Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating CHANGELOG.MD Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating CHANGELOG.MD Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> * updating CHANGELOG.MD Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: mpabba3003 <amazonmanideep@gmail.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Description
Adding unit test coverage for Update data source management
Issues Resolved
#2566
SCREENSHOTS
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr