Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LIC] Update lic header across project #259

Merged
merged 1 commit into from
Apr 9, 2021
Merged

[LIC] Update lic header across project #259

merged 1 commit into from
Apr 9, 2021

Conversation

mihirsoni
Copy link
Contributor

Signed-off-by: Mihir Soni mihirsoni.123@gmail.com

Updated the headers :

  • Added the new header
  • Added modified header
  • Updated eslint rule

@mihirsoni
[LIC] Update lic header across project
7c87c3a 
Signed-off-by: Mihir Soni <mihirsoni.123@gmail.com>
@mihirsoni mihirsoni requested a review from kavilla April 9, 2021 00:53
@mihirsoni mihirsoni added the >Fork label Apr 9, 2021
@mihirsoni mihirsoni added this to the 1.x release milestone Apr 9, 2021
@mihirsoni mihirsoni requested a review from boktorbb April 9, 2021 00:53
@odfe-release-bot
Copy link

✅   DCO Check Passed 7c87c3a

nknize
nknize approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large change. I dug in a bit and didn't see any major deviations so LGTM. I'm trusting the UT/IT all pass.

kavilla
kavilla approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Free scrolling towards the end. LGTM!

@kavilla
Copy link
Member

kavilla commented Apr 9, 2021

pulled down, lint, test, integration test and ran all working!

@mihirsoni mihirsoni merged commit e3b34df into opensearch-project:main Apr 9, 2021
@anders-swanson anders-swanson mentioned this pull request Jan 10, 2022
Closed
@tmarkley tmarkley mentioned this pull request Jan 10, 2022
Closed
@zhongnansu zhongnansu mentioned this pull request Oct 25, 2022
Merged
8 tasks
gaobinlong pushed a commit to gaobinlong/OpenSearch-Dashboards that referenced this pull request Mar 5, 2024
@raintygao
update workspace list (opensearch-project#259)
0923437 
* feat: update workspace list

Signed-off-by: tygao <tygao@amazon.com>

* test: remove failed snapshots temporarily

Signed-off-by: tygao <tygao@amazon.com>

* feat: add workspace menu

Signed-off-by: tygao <tygao@amazon.com>

* feat: add menu for table

Signed-off-by: tygao <tygao@amazon.com>

* test: add test for workspace list page

Signed-off-by: tygao <tygao@amazon.com>

* replace lodash and update props name

Signed-off-by: tygao <tygao@amazon.com>

* fix typo

Signed-off-by: tygao <tygao@amazon.com>

* update props name

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boktorbb boktorbb boktorbb approved these changes

@kavilla kavilla kavilla approved these changes

@nknize nknize nknize approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.x release
Development

Successfully merging this pull request may close these issues.
5 participants
@mihirsoni @odfe-release-bot @kavilla @nknize @boktorbb