-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Vis Builder] Rename wizard to visBuilder in class name, type name and function name #2639
[Vis Builder] Rename wizard to visBuilder in class name, type name and function name #2639
Conversation
Rname wizard to visBuilder Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
a48667c
to
71e5b0c
Compare
Codecov Report
@@ Coverage Diff @@
## main #2639 +/- ##
=======================================
Coverage ? 66.81%
=======================================
Files ? 3207
Lines ? 61149
Branches ? 9316
=======================================
Hits ? 40858
Misses ? 18060
Partials ? 2231
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -26,6 +26,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
* [Vis Builder] Change wizard to vis_builder in file names and paths ([#2587](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2587)) | |||
* [Multi DataSource] Address UX comments on Data source list and create page ([#2625](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2625)) | |||
* [Vis Builder] Rename wizard to visBuilder in i18n id and formatted message id ([#2635](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2635)) | |||
* [Vis Builder] Rename wizard to visBuilder in class name, type name and function name ([#2639](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2639)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to consolidate the changelog for all the renaming stuff. but not for this PR though.
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2639-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 74fd39fdab816dd16014acdc88d9fd649acbcf7f
# Push it to GitHub
git push --set-upstream origin backport/backport-2639-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.4 2.4
# Navigate to the new working tree
pushd ../.worktrees/backport-2.4
# Create a new branch
git switch --create backport-2639-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 74fd39fdab816dd16014acdc88d9fd649acbcf7f
# Push it to GitHub
git push --set-upstream origin backport-2639-to-2.4
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.4 Then, create a pull request where the |
#2639) (#2748) Rname wizard to visBuilder Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit 74fd39f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Will do manually. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.4 2.4
# Navigate to the new working tree
pushd ../.worktrees/backport-2.4
# Create a new branch
git switch --create backport-2639-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 74fd39fdab816dd16014acdc88d9fd649acbcf7f
# Push it to GitHub
git push --set-upstream origin backport-2639-to-2.4
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.4 Then, create a pull request where the |
opensearch-project#2639) Rname wizard to visBuilder Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
…#2770) * Change classname prefix wiz to vb (#2581) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Change wizard to vis_builder in file names and paths (#2587) Change all wizard reference in file names and paths to vis_builder Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Rename wizard to visBuilder in class name, type name and function name (#2639) Rname wizard to visBuilder Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Vis Builder] Rename wizard on save modal and visualization table (#2645) * Rename wizard on save modal and visualization table Change the wizard reference in save modal title, toggle and visualization table Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Save visualization on save modal, VisBuilder for chart type Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * No experimental flag Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Change save object type, wizard id and name to visBuilder (#2673) * Change save object type, wizard ID and Name to visBuilder Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Rename wizard in functional tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Finalize plugin-id and plugin-name and saved-object-type Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Change official name to VisBuilder Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Delete migration Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Fix functional test Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Update snapshot Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
opensearch-project#2639) Rname wizard to visBuilder Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
opensearch-project#2639) Rname wizard to visBuilder Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Reame wizard to visBuilder
Signed-off-by: abbyhu2000 abigailhu2000@gmail.com
Description
Rename wizard to visBuilder in class name, type name and function name
Issues Resolved
resolves part of #1706
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr