Apply get indice error handling in step index pattern #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristenTian
added
multiple datasource
kristenTian
force-pushed
the
OSD-main
branch
3 times, most recently
from
581020f
to
64f3de4
Compare
Error handling only happens before loading the indices to step index pattern but not within. Therefore pass the error handling inside the step as well to render error state. Signed-off-by: Kristen Tian <tyarong@amazon.com>
zhongnansu
approved these changes
Oct 24, 2022
zengyan-amazon
approved these changes
Oct 25, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
Error handling only happens before loading the indices to step index pattern but not within. Therefore pass the error handling inside the step as well to render error state. Signed-off-by: Kristen Tian <tyarong@amazon.com> (cherry picked from commit 76d30ec)
zhongnansu
pushed a commit
that referenced
this pull request
Oct 25, 2022
Error handling only happens before loading the indices to step index pattern but not within. Therefore pass the error handling inside the step as well to render error state. Signed-off-by: Kristen Tian <tyarong@amazon.com> (cherry picked from commit 76d30ec) Co-authored-by: Kristen Tian <105667444+kristenTian@users.noreply.github.com>
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this pull request
Dec 16, 2022
…ject#2652) Error handling only happens before loading the indices to step index pattern but not within. Therefore pass the error handling inside the step as well to render error state. Signed-off-by: Kristen Tian <tyarong@amazon.com> Signed-off-by: Sergey V. Osipov <sipopo@yandex.ru>
Arpit-Bandejiya
pushed a commit
to Arpit-Bandejiya/OpenSearch-Dashboards
that referenced
this pull request
Jan 13, 2023
…ject#2652) Error handling only happens before loading the indices to step index pattern but not within. Therefore pass the error handling inside the step as well to render error state. Signed-off-by: Kristen Tian <tyarong@amazon.com> Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error handling only happens before loading the indices to step index pattern but not within. Therefore pass the error handling inside the step as well to render error state.
Signed-off-by: Kristen Tian tyarong@amazon.com
Issues Resolved
#2598
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr