Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide fullpath to windows directory on REPO_ROOT #2686

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Provide fullpath to windows directory on REPO_ROOT.
This is a follow-up to #2681 to resolve the path issues on Windows due to short names vs full names.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@AMoo-Miki
Copy link
Collaborator

@peterzhuamazon, I am not sure I get the difference. Could you please elaborate?

@peterzhuamazon
Copy link
Member Author

The difference is REPO_ROOT can now be passed to the function and also return the correct path:

  const startDir = fullpath(Fs.realpathSync(__dirname));

Previously the code only allow current working directory without the param to use user-defined path.

@peterzhuamazon
Copy link
Member Author

Close this as @AMoo-Miki has a new branch.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants