-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporarily prevents task-kill
exceptions on Windows when it is passed a pid
for a process that is already dead
#2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed a `pid` for a process that is already dead Ref: opensearch-project#2811 Signed-off-by: Miki <amoo_miki@yahoo.com>
AMoo-Miki
force-pushed
the
temp-fix-2811
branch
from
November 9, 2022 07:28
6b60b5c
to
18649b7
Compare
AMoo-Miki
added
backport 2.x
v2.4.0
'Issues and PRs related to version v2.4.0'
windows
backport 2.4
labels
Nov 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #2842 +/- ##
==========================================
- Coverage 66.67% 66.67% -0.01%
==========================================
Files 3219 3219
Lines 61445 61445
Branches 9417 9417
==========================================
- Hits 40970 40966 -4
- Misses 18229 18232 +3
- Partials 2246 2247 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
joshuarrrr
approved these changes
Nov 9, 2022
kavilla
approved these changes
Nov 9, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
…sed a `pid` for a process that is already dead (#2842) Ref: #2811 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 4fd67de) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
…sed a `pid` for a process that is already dead (#2842) Ref: #2811 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 4fd67de) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ananzh
pushed a commit
that referenced
this pull request
Nov 9, 2022
…sed a `pid` for a process that is already dead (#2842) (#2845) Ref: #2811 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 4fd67de) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh
pushed a commit
that referenced
this pull request
Nov 9, 2022
…sed a `pid` for a process that is already dead (#2842) (#2844) Ref: #2811 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 4fd67de) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
…sed a `pid` for a process that is already dead (#2842) Ref: #2811 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 4fd67de) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
…sed a `pid` for a process that is already dead (#2842) Ref: #2811 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 4fd67de) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ananzh
pushed a commit
that referenced
this pull request
Dec 1, 2022
…sed a `pid` for a process that is already dead (#2842) (#2969) Ref: #2811 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 4fd67de) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Dec 1, 2022
…sed a `pid` for a process that is already dead (#2842) (#2970) Ref: #2811 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com> (cherry picked from commit 4fd67de) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AlexRuiz7
pushed a commit
to wazuh/wazuh-dashboard
that referenced
this pull request
Dec 14, 2022
…sed a `pid` for a process that is already dead (opensearch-project#2842) Ref: opensearch-project#2811 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com>
AlexRuiz7
pushed a commit
to wazuh/wazuh-dashboard
that referenced
this pull request
Dec 14, 2022
…sed a `pid` for a process that is already dead (opensearch-project#2842) Ref: opensearch-project#2811 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com>
sipopo
pushed a commit
to sipopo/OpenSearch-Dashboards
that referenced
this pull request
Dec 16, 2022
…sed a `pid` for a process that is already dead (opensearch-project#2842) Ref: opensearch-project#2811 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Sergey Osipov <sipopo@yandex.ru>
Arpit-Bandejiya
pushed a commit
to Arpit-Bandejiya/OpenSearch-Dashboards
that referenced
this pull request
Jan 13, 2023
…sed a `pid` for a process that is already dead (opensearch-project#2842) Ref: opensearch-project#2811 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
…sed a `pid` for a process that is already dead (opensearch-project#2842) Ref: opensearch-project#2811 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: David Sinclair <david@sinclair.tech>
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
…sed a `pid` for a process that is already dead (opensearch-project#2842) Ref: opensearch-project#2811 Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Miki <amoo_miki@yahoo.com> Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSD uses
tree-kill
[npm], a library that terminates a process and all of its children, for stopping processes started usingCluster
. This library behaves differently on different platforms. If thepid
it is asked to terminate is not running:As a result, calling cluster.stop() on an already terminated cluster will throw and exception on Windows but will silently continue on other operating systems.
Ref: #2811
Signed-off-by: Miki amoo_miki@yahoo.com
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr