Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fixes misleading embeddable plugin error message #3154

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport bd52024 from #3043.

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner December 28, 2022 23:44
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #3154 (7914ec8) into 2.x (0a92e60) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x    #3154      +/-   ##
==========================================
- Coverage   66.67%   66.67%   -0.01%     
==========================================
  Files        3219     3219              
  Lines       61450    61450              
  Branches     9417     9417              
==========================================
- Hits        40971    40969       -2     
+ Misses      18232    18208      -24     
- Partials     2247     2273      +26     
Flag Coverage Δ
Linux 66.67% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/embeddable/public/lib/errors.ts 100.00% <ø> (ø)
...ared/static/forms/hook_form_lib/hooks/use_field.ts 65.70% <0.00%> (-0.97%) ⬇️
packages/osd-optimizer/src/node/cache.ts 50.00% <0.00%> (ø)
packages/osd-test/src/junit_report_path.ts 62.50% <0.00%> (ø)
packages/osd-optimizer/src/run_optimizer.ts 23.52% <0.00%> (ø)
packages/osd-optimizer/src/log_optimizer_state.ts 4.54% <0.00%> (ø)
...ckages/osd-optimizer/src/report_optimizer_stats.ts 21.42% <0.00%> (ø)
...s/osd-optimizer/src/node/node_auto_tranpilation.ts 83.67% <0.00%> (ø)
...est_runner/lib/docker_servers/container_running.ts 11.76% <0.00%> (ø)
...unner/lib/docker_servers/docker_servers_service.ts 28.98% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abbyhu2000 abbyhu2000 added the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 6, 2023
Resolves #1479
Resolves #3083

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
(cherry picked from commit bd52024)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@AMoo-Miki AMoo-Miki added the autocut Skip the changelog verification check on backports label Jan 6, 2023
@abbyhu2000 abbyhu2000 merged commit be5ad88 into 2.x Jan 6, 2023
@github-actions github-actions bot deleted the backport/backport-3043-to-2.x branch January 6, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants