Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Vis Builder] Add redux store persistence #3172

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport bfc59d4 from #3088.

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 3, 2023 22:00
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #3172 (2e3c20c) into 2.x (ea36d5a) will increase coverage by 0.08%.
The diff coverage is 73.33%.

@@            Coverage Diff             @@
##              2.x    #3172      +/-   ##
==========================================
+ Coverage   66.59%   66.68%   +0.08%     
==========================================
  Files        3219     3220       +1     
  Lines       61531    61544      +13     
  Branches     9431     9432       +1     
==========================================
+ Hits        40978    41041      +63     
+ Misses      18308    18262      -46     
+ Partials     2245     2241       -4     
Flag Coverage Δ
Linux 66.63% <73.33%> (+0.03%) ⬆️
Windows 66.63% <73.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/data/public/mocks.ts 83.33% <ø> (ø)
...public/application/utils/state_management/store.ts 14.28% <0.00%> (-0.72%) ⬇️
...cation/utils/state_management/redux_persistence.ts 80.00% <80.00%> (ø)
...gins/vis_builder/public/application/utils/mocks.ts 100.00% <100.00%> (ø)
...ic/application/models/sense_editor/sense_editor.ts 64.88% <0.00%> (+0.88%) ⬆️
packages/osd-optimizer/src/node/cache.ts 51.31% <0.00%> (+1.31%) ⬆️
src/dev/build/lib/config.ts 85.29% <0.00%> (+5.88%) ⬆️
...ges/osd-apm-config-loader/src/config.test.mocks.ts 100.00% <0.00%> (+8.69%) ⬆️
...tion/utils/state_management/visualization_slice.ts 36.11% <0.00%> (+19.44%) ⬆️
...plication/utils/state_management/metadata_slice.ts 61.53% <0.00%> (+23.07%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abbyhu2000 abbyhu2000 added the autocut Skip the changelog verification check on backports label Jan 4, 2023
abbyhu2000
abbyhu2000 previously approved these changes Jan 5, 2023
manasvinibs
manasvinibs previously approved these changes Jan 5, 2023
@manasvinibs manasvinibs added the v2.5.0 'Issues and PRs related to version v2.5.0' label Jan 5, 2023
@manasvinibs manasvinibs force-pushed the backport/backport-3088-to-2.x branch from 2e3c20c to 52c742f Compare January 5, 2023 22:20
@AMoo-Miki AMoo-Miki dismissed stale reviews from manasvinibs and abbyhu2000 via 52c742f January 6, 2023 04:23
* add redux store persistence

implement persistence without using state container or state sync utils, and it
works with both the URL and session storage.

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* changelog and rebase

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Console log the error

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* rebase and changelog

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add unit tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
(cherry picked from commit bfc59d4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@manasvinibs manasvinibs force-pushed the backport/backport-3088-to-2.x branch from 52c742f to 58eaf69 Compare January 6, 2023 20:37
@abbyhu2000 abbyhu2000 merged commit 0e7796b into 2.x Jan 6, 2023
@github-actions github-actions bot deleted the backport/backport-3088-to-2.x branch January 6, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants