Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.5] [VisBuilder] fixes filters for table visualisation #3233

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport fba380b from #3210.

* fixes table vis for filter aggregation types

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Fixes filter and add error boundry

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Adds changelog

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit fba380b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 9, 2023 23:47
@joshuarrrr joshuarrrr added v2.5.0 'Issues and PRs related to version v2.5.0' autocut Skip the changelog verification check on backports labels Jan 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3233 (26b1d85) into 2.5 (1779726) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              2.5    #3233      +/-   ##
==========================================
+ Coverage   66.53%   66.54%   +0.01%     
==========================================
  Files        3200     3200              
  Lines       61287    61295       +8     
  Branches     9439     9440       +1     
==========================================
+ Hits        40775    40790      +15     
+ Misses      18257    18249       -8     
- Partials     2255     2256       +1     
Flag Coverage Δ
Linux 66.49% <0.00%> (+0.01%) ⬆️
Windows 66.49% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pplication/components/data_tab/secondary_panel.tsx 1.96% <0.00%> (-0.37%) ⬇️
..._builder/public/application/components/top_nav.tsx 4.34% <ø> (ø)
src/plugins/vis_builder/public/plugin.ts 23.40% <ø> (ø)
.../components/data_tab/utils/get_available_fields.ts 100.00% <0.00%> (+75.00%) ⬆️
...ion/components/data_tab/utils/get_field_details.ts 90.00% <0.00%> (+90.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abbyhu2000 abbyhu2000 merged commit 0c02514 into 2.5 Jan 10, 2023
@github-actions github-actions bot deleted the backport/backport-3210-to-2.5 branch January 10, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants