-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Manual backport 1.x] Updates NOTICE file, adds validation to GitHub CI & Corrects NOTICE f… #3453
Conversation
…#3051) * Aligns NOTICE with rules outlined in opensearch-project/.github#21. * Adds NOTICE validation to the build and test workflow. * Fixes product name discrepancies between repository NOTICE file and the generated NOTICE file for the build. * Skips template-izing the build and test workflow since that's being worked on in opensearch-project#2991. Resolves opensearch-project#765 Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com>
* Corrects NOTICE file copyright date range * Follow-up on opensearch-project#3051 Resolves opensearch-project#765 Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 1.x #3453 +/- ##
==========================================
+ Coverage 67.45% 67.50% +0.05%
==========================================
Files 3044 3044
Lines 58697 58692 -5
Branches 8902 8902
==========================================
+ Hits 39592 39619 +27
+ Misses 16952 16925 -27
+ Partials 2153 2148 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Do we know that 1.x does not use any of those software removed from the NOTICE file? I have a feeling that we intentionally left these changes out of 1.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also #3452 (review) about date range start change
@AMoo-Miki This PR also includes a workflow step to validate that the notice file is accurate and it passes that step. I also manually validated the ones that were removed and they dont exist in the repo. |
…CI & Corrects NOTICE f… (#3453) * Updates NOTICE file, adds validation to GitHub CI (#3051) * Aligns NOTICE with rules outlined in opensearch-project/.github#21. * Adds NOTICE validation to the build and test workflow. * Fixes product name discrepancies between repository NOTICE file and the generated NOTICE file for the build. * Skips template-izing the build and test workflow since that's being worked on in #2991. Resolves #765 Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * Corrects NOTICE file copyright date range (#3308) * Corrects NOTICE file copyright date range * Follow-up on #3051 Resolves #765 Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> * Update CHANGELOG.md Co-authored-by: Miki <amoo_miki@yahoo.com> Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com> --------- Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Co-authored-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> (cherry picked from commit bf1c65f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…CI & Corrects NOTICE f… (#3453) (#3596) * Updates NOTICE file, adds validation to GitHub CI (#3051) * Aligns NOTICE with rules outlined in opensearch-project/.github#21. * Adds NOTICE validation to the build and test workflow. * Fixes product name discrepancies between repository NOTICE file and the generated NOTICE file for the build. * Skips template-izing the build and test workflow since that's being worked on in #2991. Resolves #765 * Corrects NOTICE file copyright date range (#3308) * Corrects NOTICE file copyright date range * Follow-up on #3051 Resolves #765 * Update CHANGELOG.md --------- (cherry picked from commit bf1c65f) Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Miki <amoo_miki@yahoo.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
…ile copyright date range
Resolves #765
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr