Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 1.x] Simplifies re2 upgrade instructions (#3328) #3561

Merged

Conversation

joshuarrrr
Copy link
Member

Backport 844059c from #3328.

* Follow-up from opensearch-project#3018

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
(cherry picked from commit 844059c)
kavilla
kavilla previously approved these changes Mar 8, 2023
AMoo-Miki
AMoo-Miki previously approved these changes Mar 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Merging #3561 (20e8510) into 1.x (3a51afd) will increase coverage by 0.04%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              1.x    #3561      +/-   ##
==========================================
+ Coverage   67.45%   67.49%   +0.04%     
==========================================
  Files        3044     3044              
  Lines       58696    58696              
  Branches     8902     8902              
==========================================
+ Hits        39593    39617      +24     
+ Misses      16951    16931      -20     
+ Partials     2152     2148       -4     
Flag Coverage Δ
Linux 67.45% <ø> (ø)
Windows 67.44% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/dev/build/tasks/patch_native_modules_task.ts 86.20% <ø> (ø)
src/setup_node_env/harden/child_process.js 88.46% <0.00%> (+3.84%) ⬆️
src/dev/build/lib/config.ts 85.29% <0.00%> (+5.88%) ⬆️
...ges/osd-apm-config-loader/src/config.test.mocks.ts 100.00% <0.00%> (+8.69%) ⬆️
packages/osd-cross-platform/src/path.ts 86.04% <0.00%> (+37.20%) ⬆️
src/dev/build/lib/get_build_number.ts 100.00% <0.00%> (+42.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr joshuarrrr dismissed stale reviews from AMoo-Miki and kavilla via 20e8510 March 8, 2023 22:28
@joshuarrrr
Copy link
Member Author

ignoring whitesource check for docs/comment-only change

@joshuarrrr joshuarrrr merged commit 3107769 into opensearch-project:1.x Mar 9, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 9, 2023
* Follow-up from #3018

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
(cherry picked from commit 844059c)

Co-authored-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
(cherry picked from commit 3107769)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
joshuarrrr pushed a commit that referenced this pull request Mar 9, 2023
* Follow-up from #3018

Signed-off-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
(cherry picked from commit 844059c)

Co-authored-by: Tommy Markley <5437176+tmarkley@users.noreply.github.com>
(cherry picked from commit 3107769)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@joshuarrrr joshuarrrr deleted the backport/backport-3328-to-1.x branch March 10, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants