Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and rebuild @osd/pm #3570

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Cleanup and rebuild @osd/pm #3570

merged 1 commit into from
Mar 20, 2023

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Mar 9, 2023 •
edited
Loading

Description

  • Fixed the build failures
  • Removed some unused packages
  • Rebuilt dist of @osd/pm

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@AMoo-Miki AMoo-Miki requested a review from a team as a code owner March 9, 2023 03:47
@seraphjiang
Copy link
Member

Has the build issue caught by any automation test?

@seraphjiang
Copy link
Member

For process to update dust/index.Js do we have it covered in any release doc or developer guideline doc

@AMoo-Miki
Copy link
Collaborator Author

Link Checker complaining about https://codeload.github.com/gist/{project}/tar.gz/{committish} can be ignored.

@AMoo-Miki
Copy link
Collaborator Author

Has the build issue caught by any automation test?

No. dist contains a prebuilt one and no changes have gone into @osd/pm to warrant a rebuild.

@AMoo-Miki
Copy link
Collaborator Author

AMoo-Miki commented Mar 9, 2023 •
edited
Loading

For process to update dust/index.Js do we have it covered in any release doc or developer guideline doc

The package has complete documentation of this.

@AMoo-Miki AMoo-Miki changed the title Rebuild @osd/pm Cleanup and rebuild @osd/pm Mar 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023 •
edited
Loading

Codecov Report

Merging #3570 (829c183) into main (1e127b0) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 829c183 differs from pull request most recent head 6bdebda. Consider uploading reports for the commit 6bdebda to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #3570   +/-   ##
=======================================
  Coverage   66.41%   66.41%           
=======================================
  Files        3206     3206           
  Lines       61597    61597           
  Branches     9503     9503           
=======================================
+ Hits        40909    40911    +2     
+ Misses      18410    18409    -1     
+ Partials     2278     2277    -1
Flag Coverage Δ
Linux ?
Windows 66.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshuarrrr
Copy link
Member

Link Checker complaining about https://codeload.github.com/gist/{project}/tar.gz/{committish} can be ignored.

@AMoo-Miki You need to add that to .lycheexclude. Otherwise it will fail for all other subsequent PRs. Or are you saying it's a transient issue?

@AMoo-Miki
Copy link
Collaborator Author

AMoo-Miki commented Mar 13, 2023 •
edited
Loading

Link Checker complaining about https://codeload.github.com/gist/{project}/tar.gz/{committish} can be ignored.

@AMoo-Miki You need to add that to .lycheexclude. Otherwise it will fail for all other subsequent PRs. Or are you saying it's a transient issue?

I think it only complains in changed files as it is not complaining about it right now. However, you are right, let's save ourselves from this complaining in the future. I will add it to the ignore list.

@AMoo-Miki
Clean up and rebuild @osd/pm
6bdebda 
* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <miki@amazon.com>
@joshuarrrr joshuarrrr merged commit f8c9182 into opensearch-project:main Mar 20, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 20, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2023
@github-actions
Clean up and rebuild @osd/pm (#3570)
1c90218 
* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit f8c9182)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
kappassov pushed a commit to kappassov/OpenSearch-Dashboards that referenced this pull request Mar 21, 2023
@AMoo-Miki @kappassov
Clean up and rebuild @osd/pm (opensearch-project#3570)
95a0b24 
* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <miki@amazon.com>
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Mar 22, 2023
@AMoo-Miki
Clean up and rebuild @osd/pm (opensearch-project#3570)
926aca9 
* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <miki@amazon.com>
abbyhu2000 pushed a commit that referenced this pull request Mar 22, 2023
@kappassov @ananzh
@AMoo-Miki @zhongnansu
[CCI] Adding second command to Install yarn step in Developer Guide (#…
b0146e7 
…3633)

* added prepare command

Signed-off-by: kappassov <abayk0708@gmail.com>

* Use mirrors to download Node.js binaries to escape sporadic 404 errors (#3619)

Issue Resolved:
#3618

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Allow selecting the Node.js binary OSD uses (#3508)

New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD.
* The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary.
* Update `package.json` to replace `node` with `use_node`.
* Update file templates and shell scripts to internally use `use_node`.
* Update the build scripts to copy `use_node` into releases
* Make tests that execute node internally, honor the binary being used.

Signed-off-by: Miki <miki@amazon.com>

* Clean up and rebuild @osd/pm (#3570)

* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <miki@amazon.com>

* Refactor dev tool console to use opensearch-js client to send request (#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <szhongna@amazon.com>

* updates after the 1st review

Signed-off-by: kappassov <abayk0708@gmail.com>

---------

Signed-off-by: kappassov <abayk0708@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Su <szhongna@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 22, 2023
@github-actions @ananzh
@AMoo-Miki @zhongnansu
[CCI] Adding second command to Install yarn step in Developer Guide (#…
a91302d 
…3633)

* added prepare command

Signed-off-by: kappassov <abayk0708@gmail.com>

* Use mirrors to download Node.js binaries to escape sporadic 404 errors (#3619)

Issue Resolved:
#3618

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Allow selecting the Node.js binary OSD uses (#3508)

New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD.
* The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary.
* Update `package.json` to replace `node` with `use_node`.
* Update file templates and shell scripts to internally use `use_node`.
* Update the build scripts to copy `use_node` into releases
* Make tests that execute node internally, honor the binary being used.

Signed-off-by: Miki <miki@amazon.com>

* Clean up and rebuild @osd/pm (#3570)

* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <miki@amazon.com>

* Refactor dev tool console to use opensearch-js client to send request (#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <szhongna@amazon.com>

* updates after the 1st review

Signed-off-by: kappassov <abayk0708@gmail.com>

---------

Signed-off-by: kappassov <abayk0708@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Su <szhongna@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
(cherry picked from commit b0146e7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000 pushed a commit that referenced this pull request Mar 22, 2023
@opensearch-trigger-bot @github-actions
@ananzh @AMoo-Miki @zhongnansu
[CCI] Adding second command to Install yarn step in Developer Guide (#…
3d2082a 
…3633) (#3651)

* added prepare command



* Use mirrors to download Node.js binaries to escape sporadic 404 errors (#3619)

Issue Resolved:
#3618



* Allow selecting the Node.js binary OSD uses (#3508)

New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD.
* The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary.
* Update `package.json` to replace `node` with `use_node`.
* Update file templates and shell scripts to internally use `use_node`.
* Update the build scripts to copy `use_node` into releases
* Make tests that execute node internally, honor the binary being used.



* Clean up and rebuild @osd/pm (#3570)

* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list



* Refactor dev tool console to use opensearch-js client to send request (#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch



* updates after the 1st review



---------








(cherry picked from commit b0146e7)

Signed-off-by: kappassov <abayk0708@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Su <szhongna@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
pjfitzgibbons pushed a commit to pjfitzgibbons/OpenSearch-Dashboards that referenced this pull request Mar 24, 2023
@kappassov @ananzh
@AMoo-Miki @zhongnansu
[CCI] Adding second command to Install yarn step in Developer Guide (o…
9821c56 
…pensearch-project#3633)

* added prepare command

Signed-off-by: kappassov <abayk0708@gmail.com>

* Use mirrors to download Node.js binaries to escape sporadic 404 errors (opensearch-project#3619)

Issue Resolved:
opensearch-project#3618

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Allow selecting the Node.js binary OSD uses (opensearch-project#3508)

New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD.
* The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary.
* Update `package.json` to replace `node` with `use_node`.
* Update file templates and shell scripts to internally use `use_node`.
* Update the build scripts to copy `use_node` into releases
* Make tests that execute node internally, honor the binary being used.

Signed-off-by: Miki <miki@amazon.com>

* Clean up and rebuild @osd/pm (opensearch-project#3570)

* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <miki@amazon.com>

* Refactor dev tool console to use opensearch-js client to send request (opensearch-project#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <szhongna@amazon.com>

* updates after the 1st review

Signed-off-by: kappassov <abayk0708@gmail.com>

---------

Signed-off-by: kappassov <abayk0708@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Su <szhongna@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@AMoo-Miki @sikhote
Clean up and rebuild @osd/pm (opensearch-project#3570)
d442537 
* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@kappassov @ananzh
@AMoo-Miki @zhongnansu @sikhote
[CCI] Adding second command to Install yarn step in Developer Guide (o…
5c7953a 
…pensearch-project#3633)

* added prepare command

Signed-off-by: kappassov <abayk0708@gmail.com>

* Use mirrors to download Node.js binaries to escape sporadic 404 errors (opensearch-project#3619)

Issue Resolved:
opensearch-project#3618

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Allow selecting the Node.js binary OSD uses (opensearch-project#3508)

New reusable use_node scripts take care of selecting the correct Node.js binary based OSD_NODE_HOME, OSD_HOME, and whatever is in the PATH. It also takes care of finding the binary on FreeBSD.
* The startup scripts check `OSD_NODE_HOME` and `NODE_HOME` before falling back to use the bundled or system-wide Node.js binary.
* Update `package.json` to replace `node` with `use_node`.
* Update file templates and shell scripts to internally use `use_node`.
* Update the build scripts to copy `use_node` into releases
* Make tests that execute node internally, honor the binary being used.

Signed-off-by: Miki <miki@amazon.com>

* Clean up and rebuild @osd/pm (opensearch-project#3570)

* Fix the build failures
* Removed some unused packages
* Update gist url templates in Lychee's exclusion list

Signed-off-by: Miki <miki@amazon.com>

* Refactor dev tool console to use opensearch-js client to send request (opensearch-project#3544)

Refactor dev tool console to use opensearch-js client to interact with OpenSearch

Signed-off-by: Su <szhongna@amazon.com>

* updates after the 1st review

Signed-off-by: kappassov <abayk0708@gmail.com>

---------

Signed-off-by: kappassov <abayk0708@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Su <szhongna@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuarrrr joshuarrrr joshuarrrr approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

Assignees

@AMoo-Miki AMoo-Miki

Labels
backport 2.x v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AMoo-Miki @seraphjiang @codecov-commenter @joshuarrrr @ashwin-pc