-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting savedAugmentVisLoader in Visualizations plugin #3616
Setting savedAugmentVisLoader in Visualizations plugin #3616
Conversation
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
f5d07b7
to
22b11eb
Compare
We have a circular dependency issue if we add |
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Applied fix |
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## feature/feature-anywhere #3616 +/- ##
============================================================
- Coverage 66.58% 66.42% -0.17%
============================================================
Files 3216 3218 +2
Lines 61506 61748 +242
Branches 9476 9520 +44
============================================================
+ Hits 40954 41015 +61
- Misses 18294 18454 +160
- Partials 2258 2279 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite sure if this is the correct final dependency model, but it's something we can revisit in context for the final review. Will approve to unblock branch development.
Description
Currently when utilizing the latest commit in feature-anywhere branch while trying to use it as a dependency in the ad plugin I get an error displaying any visualizations across all of dashboards since the visAugment loader needs to be set before calling get in visualizations plugin. Related comment here: https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3131/files#r1137998192
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr