[CCI][#3590]Indicate that IE is no longer supported #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frost017
changed the title
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3641 +/- ##
=======================================
Coverage 66.36% 66.36%
=======================================
Files 3209 3209
Lines 61732 61732
Branches 9533 9533
=======================================
Hits 40968 40968
Misses 18470 18470
Partials 2294 2294
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@AMoo-Miki @kavilla I don't get why some tests are failing, just I haven't changed or added logical code |
joshuarrrr
reviewed
Mar 22, 2023
AMoo-Miki
previously requested changes
Mar 22, 2023
Signed-off-by: Raiymbek Aiymbet <r.aiymbet@gmail.com>
Signed-off-by: Raiymbek Aiymbet <r.aiymbet@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Raiymbek Aiymbet <r.aiymbet@gmail.com>
Signed-off-by: Raiymbek Aiymbet <r.aiymbet@gmail.com>
frost017
force-pushed
the
ie-not-supported
branch
from
870c56d
to
2296f30
Compare
frost017
requested review from
AMoo-Miki and
joshuarrrr
and removed request for
AMoo-Miki and
joshuarrrr
23 tasks
|
@frost017 Don't worry about trying to keep the branch up to date - we'll try and get one completely passing workflow first. |
joshuarrrr
previously approved these changes
Apr 11, 2023
joshuarrrr
requested review from
ananzh,
kavilla,
seanneumann,
ashwin-pc,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu and
manasvinibs
as code owners
|
all checks passed prior to changelog conflict resolution. |
joshuarrrr
approved these changes
Apr 12, 2023
AMoo-Miki
approved these changes
Apr 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 13, 2023
* [#3590]Indicate that IE is no longer supported * Update src/core/public/chrome/chrome_service.tsx --------- Signed-off-by: Raiymbek Aiymbet <r.aiymbet@gmail.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 0a83c47) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Apr 15, 2023
…3839) * [CCI][#3590]Indicate that IE is no longer supported (#3641) * [#3590]Indicate that IE is no longer supported * Update src/core/public/chrome/chrome_service.tsx --------- Signed-off-by: Raiymbek Aiymbet <r.aiymbet@gmail.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 0a83c47) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * update changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> * update changelog correctly Signed-off-by: Josh Romero <rmerqg@amazon.com> * restore changelog and update Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Raiymbek Aiymbet <r.aiymbet@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <rmerqg@amazon.com>
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
…opensearch-project#3641) * [opensearch-project#3590]Indicate that IE is no longer supported * Update src/core/public/chrome/chrome_service.tsx --------- Signed-off-by: Raiymbek Aiymbet <r.aiymbet@gmail.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now the language clearly indicates that IE is no longer supported.
Issues Resolved
#3590
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr