Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update favicons with new OpenSearch branding #369

Merged
merged 1 commit into from
May 26, 2021

Conversation

tmarkley
Copy link
Contributor

@tmarkley tmarkley commented May 24, 2021

Signed-off-by: Tommy Markley markleyt@amazon.com

Description

Updates the favicons using the new OpenSearch branding. Favicons were generated with https://realfavicongenerator.net.

Issues Resolved

#368

Screenshot

favicon screenshot

Check List

  • New functionality includes testing.
    • Unit tests pass
    • Integration tests pass
    • Functional tests pass
  • New functionality has been documented. https://opensearch.org/brand.html
    • New functionality has javadoc added (N/A)
  • Commits are signed per the DCO using --signoff

…#368)

Signed-off-by: Tommy Markley <markleyt@amazon.com>
@tmarkley tmarkley self-assigned this May 24, 2021
@tmarkley tmarkley changed the title Update favicon icons with new OpenSearch branding (#368) Update favicon icons with new OpenSearch branding May 24, 2021
@tmarkley tmarkley changed the title Update favicon icons with new OpenSearch branding Update favicons with new OpenSearch branding May 24, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 1466ea4

@kavilla
Copy link
Member

kavilla commented May 25, 2021

This looks good, anything particular you wanted us to see with the draft?

@tmarkley
Copy link
Contributor Author

This looks good, anything particular you wanted us to see with the draft?

I just wanted to make sure the format was correct and the content was sufficient.

@tmarkley tmarkley marked this pull request as ready for review May 25, 2021 23:31
@tmarkley tmarkley linked an issue May 25, 2021 that may be closed by this pull request
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmarkley tmarkley merged commit 858cc07 into opensearch-project:main May 26, 2021
@tmarkley tmarkley deleted the osd-368 branch May 26, 2021 20:32
kavilla pushed a commit that referenced this pull request May 26, 2021
Signed-off-by: Tommy Markley <markleyt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update favicons with new branding
4 participants