-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] [Console] Fixed/updated documentation links in Dev Tools console #3724
[Docs] [Console] Fixed/updated documentation links in Dev Tools console #3724
Conversation
Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
…cause corresponding pages are missing/not yet written in documentation Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
… and exists Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
…ex page https://opensearch.org/docs/ Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
…script_languages Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
… pages Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
… pages Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
…on to the general page about processors https://opensearch.org/docs/latest/data-prepper/pipelines/configuration/processors/processors/ Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Thanks Sirazh for this. |
@curq This is awesome - I'm excited to get it in the next release! I'm reviewing today and should have some feedback shortly. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3724 +/- ##
==========================================
- Coverage 66.43% 66.37% -0.07%
==========================================
Files 3210 3210
Lines 61677 61677
Branches 9522 9522
==========================================
- Hits 40977 40939 -38
- Misses 18419 18450 +31
- Partials 2281 2288 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@curq Thanks, this is excellent - great job finding the most relevant doc available. I was able to find just a couple more, and in some cases, even where we don't have docs available, I think we can at least get the user closer, so I made some suggestions along those lines.
@@ -14,6 +14,6 @@ | |||
"patterns": [ | |||
"_cat/master" | |||
], | |||
"documentation": "https://opensearch.org/docs/latest/opensearch/rest-api/cat/cat-master/" | |||
"documentation": "https://opensearch.org/docs/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of scope for this PR, but this has been deprecated, updated to https://opensearch.org/docs/latest/api-reference/cat/cat-cluster_manager/ - I'll make a separate issue to update.
...sole/server/lib/spec_definitions/json/generated/cluster.delete_voting_config_exclusions.json
Outdated
Show resolved
Hide resolved
src/plugins/console/server/lib/spec_definitions/json/generated/cluster.pending_tasks.json
Outdated
Show resolved
Hide resolved
...sole/server/lib/spec_definitions/json/generated/cluster.delete_voting_config_exclusions.json
Outdated
Show resolved
Hide resolved
src/plugins/console/server/lib/spec_definitions/json/generated/remote_store.restore.json
Outdated
Show resolved
Hide resolved
src/plugins/console/server/lib/spec_definitions/json/generated/snapshot.cleanup_repository.json
Outdated
Show resolved
Hide resolved
src/plugins/console/server/lib/spec_definitions/json/generated/snapshot.clone.json
Outdated
Show resolved
Hide resolved
src/plugins/console/server/lib/spec_definitions/json/generated/tasks.cancel.json
Outdated
Show resolved
Hide resolved
src/plugins/console/server/lib/spec_definitions/json/generated/indices.exists_template.json
Outdated
Show resolved
Hide resolved
Failing cypress test workflow can be ignored |
Thank you for your review @joshuarrrr |
This is amazing! Thanks @curq!! |
…cs/latest/api-reference/cluster-api/index/ Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
…cs/latest/api-reference/index-apis/index/ Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
I added some more changes after reviewing the feedback here is short summary of changes:
In the suggestions above I commented some of my reasoning behind the changes. |
@curq Thanks for all the updates and explanations. I'm running all the automated workflows now, but expect to be able to approve soon. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.x 1.x
# Navigate to the new working tree
pushd ../.worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-3724-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 01a0baf4a62725ee6e53f5f3c65fb4c4eb0e09c0
# Push it to GitHub
git push --set-upstream origin backport/backport-3724-to-1.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-3724-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 01a0baf4a62725ee6e53f5f3c65fb4c4eb0e09c0
# Push it to GitHub
git push --set-upstream origin backport/backport-3724-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-1.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3724-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 01a0baf4a62725ee6e53f5f3c65fb4c4eb0e09c0
# Push it to GitHub
git push --set-upstream origin backport/backport-3724-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3724-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 01a0baf4a62725ee6e53f5f3c65fb4c4eb0e09c0
# Push it to GitHub
git push --set-upstream origin backport/backport-3724-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3724-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 01a0baf4a62725ee6e53f5f3c65fb4c4eb0e09c0
# Push it to GitHub
git push --set-upstream origin backport/backport-3724-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
…le (opensearch-project#3724) * Update console documentation links to corresponding documentation pages * Update console documentation links to https://opensearch.org/docs/ because corresponding pages are missing/not yet written in documentation * Update console documentation links for component_template delete, get and exists * Update console documentation links for info.json and ping.json to index page https://opensearch.org/docs/ * Fix: added missing documentation links to get_script_context and get_script_languages * Update links to processors in comments to their working documentation pages * Update links to processors with no corresponding pages in documentation to the general page about processors https://opensearch.org/docs/latest/data-prepper/pipelines/configuration/processors/processors/ * Update CHANGELOG.md * Update cluster.* links with missing docs to https://opensearch.org/docs/latest/api-reference/cluster-api/index/ * Update indices.* links with missing docs to https://opensearch.org/docs/latest/api-reference/index-apis/index/ * Update links with anchor # if applicable * Update links Co-authored-by: Zhongnan Su <szhongna@amazon.com> --------- Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 01a0baf)
…nks in Dev Tools console (#3883) * [Docs] [Console] Fixed/updated documentation links in Dev Tools console (#3724) * Update console documentation links to corresponding documentation pages * Update console documentation links to https://opensearch.org/docs/ because corresponding pages are missing/not yet written in documentation * Update console documentation links for component_template delete, get and exists * Update console documentation links for info.json and ping.json to index page https://opensearch.org/docs/ * Fix: added missing documentation links to get_script_context and get_script_languages * Update links to processors in comments to their working documentation pages * Update links to processors with no corresponding pages in documentation to the general page about processors https://opensearch.org/docs/latest/data-prepper/pipelines/configuration/processors/processors/ * Update CHANGELOG.md * Update cluster.* links with missing docs to https://opensearch.org/docs/latest/api-reference/cluster-api/index/ * Update indices.* links with missing docs to https://opensearch.org/docs/latest/api-reference/index-apis/index/ * Update links with anchor # if applicable * Update links Co-authored-by: Zhongnan Su <szhongna@amazon.com> --------- Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 01a0baf) * remove changelog additions Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
…nks in Dev Tools console (#3883) * [Docs] [Console] Fixed/updated documentation links in Dev Tools console (#3724) * Update console documentation links to corresponding documentation pages * Update console documentation links to https://opensearch.org/docs/ because corresponding pages are missing/not yet written in documentation * Update console documentation links for component_template delete, get and exists * Update console documentation links for info.json and ping.json to index page https://opensearch.org/docs/ * Fix: added missing documentation links to get_script_context and get_script_languages * Update links to processors in comments to their working documentation pages * Update links to processors with no corresponding pages in documentation to the general page about processors https://opensearch.org/docs/latest/data-prepper/pipelines/configuration/processors/processors/ * Update CHANGELOG.md * Update cluster.* links with missing docs to https://opensearch.org/docs/latest/api-reference/cluster-api/index/ * Update indices.* links with missing docs to https://opensearch.org/docs/latest/api-reference/index-apis/index/ * Update links with anchor # if applicable * Update links Co-authored-by: Zhongnan Su <szhongna@amazon.com> --------- Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 01a0baf) * remove changelog additions Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> (cherry picked from commit 46b76b3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…nks in Dev Tools console (#3883) (#3893) * [Docs] [Console] Fixed/updated documentation links in Dev Tools console (#3724) * Update console documentation links to corresponding documentation pages * Update console documentation links to https://opensearch.org/docs/ because corresponding pages are missing/not yet written in documentation * Update console documentation links for component_template delete, get and exists * Update console documentation links for info.json and ping.json to index page https://opensearch.org/docs/ * Fix: added missing documentation links to get_script_context and get_script_languages * Update links to processors in comments to their working documentation pages * Update links to processors with no corresponding pages in documentation to the general page about processors https://opensearch.org/docs/latest/data-prepper/pipelines/configuration/processors/processors/ * Update CHANGELOG.md * Update cluster.* links with missing docs to https://opensearch.org/docs/latest/api-reference/cluster-api/index/ * Update indices.* links with missing docs to https://opensearch.org/docs/latest/api-reference/index-apis/index/ * Update links with anchor # if applicable * Update links --------- (cherry picked from commit 01a0baf) * remove changelog additions --------- (cherry picked from commit 46b76b3) Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
…le (opensearch-project#3724) * Update console documentation links to corresponding documentation pages * Update console documentation links to https://opensearch.org/docs/ because corresponding pages are missing/not yet written in documentation * Update console documentation links for component_template delete, get and exists * Update console documentation links for info.json and ping.json to index page https://opensearch.org/docs/ * Fix: added missing documentation links to get_script_context and get_script_languages * Update links to processors in comments to their working documentation pages * Update links to processors with no corresponding pages in documentation to the general page about processors https://opensearch.org/docs/latest/data-prepper/pipelines/configuration/processors/processors/ * Update CHANGELOG.md * Update cluster.* links with missing docs to https://opensearch.org/docs/latest/api-reference/cluster-api/index/ * Update indices.* links with missing docs to https://opensearch.org/docs/latest/api-reference/index-apis/index/ * Update links with anchor # if applicable * Update links Co-authored-by: Zhongnan Su <szhongna@amazon.com> --------- Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: David Sinclair <david@sinclair.tech>
…le (opensearch-project#3724) * Update console documentation links to corresponding documentation pages * Update console documentation links to https://opensearch.org/docs/ because corresponding pages are missing/not yet written in documentation * Update console documentation links for component_template delete, get and exists * Update console documentation links for info.json and ping.json to index page https://opensearch.org/docs/ * Fix: added missing documentation links to get_script_context and get_script_languages * Update links to processors in comments to their working documentation pages * Update links to processors with no corresponding pages in documentation to the general page about processors https://opensearch.org/docs/latest/data-prepper/pipelines/configuration/processors/processors/ * Update CHANGELOG.md * Update cluster.* links with missing docs to https://opensearch.org/docs/latest/api-reference/cluster-api/index/ * Update indices.* links with missing docs to https://opensearch.org/docs/latest/api-reference/index-apis/index/ * Update links with anchor # if applicable * Update links Co-authored-by: Zhongnan Su <szhongna@amazon.com> --------- Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 01a0baf)
backporting wasn't completed in time for 1.3.10 - relabeling for 1.3.11. |
…le (#3724) (#3986) * Update console documentation links to corresponding documentation pages * Update console documentation links to https://opensearch.org/docs/ because corresponding pages are missing/not yet written in documentation * Update console documentation links for component_template delete, get and exists * Update console documentation links for info.json and ping.json to index page https://opensearch.org/docs/ * Fix: added missing documentation links to get_script_context and get_script_languages * Update links to processors in comments to their working documentation pages * Update links to processors with no corresponding pages in documentation to the general page about processors https://opensearch.org/docs/latest/data-prepper/pipelines/configuration/processors/processors/ * Update CHANGELOG.md * Update cluster.* links with missing docs to https://opensearch.org/docs/latest/api-reference/cluster-api/index/ * Update indices.* links with missing docs to https://opensearch.org/docs/latest/api-reference/index-apis/index/ * Update links with anchor # if applicable * Update links Co-authored-by: Zhongnan Su <szhongna@amazon.com> --------- Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 01a0baf) Co-authored-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
…le (#3724) (#3986) * Update console documentation links to corresponding documentation pages * Update console documentation links to https://opensearch.org/docs/ because corresponding pages are missing/not yet written in documentation * Update console documentation links for component_template delete, get and exists * Update console documentation links for info.json and ping.json to index page https://opensearch.org/docs/ * Fix: added missing documentation links to get_script_context and get_script_languages * Update links to processors in comments to their working documentation pages * Update links to processors with no corresponding pages in documentation to the general page about processors https://opensearch.org/docs/latest/data-prepper/pipelines/configuration/processors/processors/ * Update CHANGELOG.md * Update cluster.* links with missing docs to https://opensearch.org/docs/latest/api-reference/cluster-api/index/ * Update indices.* links with missing docs to https://opensearch.org/docs/latest/api-reference/index-apis/index/ * Update links with anchor # if applicable * Update links Co-authored-by: Zhongnan Su <szhongna@amazon.com> --------- Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Co-authored-by: Zhongnan Su <szhongna@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit 01a0baf) Co-authored-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> (cherry picked from commit 916c096) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…le (#3724) (#3986) (#4145) * Update console documentation links to corresponding documentation pages * Update console documentation links to https://opensearch.org/docs/ because corresponding pages are missing/not yet written in documentation * Update console documentation links for component_template delete, get and exists * Update console documentation links for info.json and ping.json to index page https://opensearch.org/docs/ * Fix: added missing documentation links to get_script_context and get_script_languages * Update links to processors in comments to their working documentation pages * Update links to processors with no corresponding pages in documentation to the general page about processors https://opensearch.org/docs/latest/data-prepper/pipelines/configuration/processors/processors/ * Update CHANGELOG.md * Update cluster.* links with missing docs to https://opensearch.org/docs/latest/api-reference/cluster-api/index/ * Update indices.* links with missing docs to https://opensearch.org/docs/latest/api-reference/index-apis/index/ * Update links with anchor # if applicable * Update links --------- (cherry picked from commit 01a0baf) (cherry picked from commit 916c096) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Description
https://opensearch.org/docs/
https://opensearch.org/docs/latest/data-prepper/pipelines/configuration/processors/processors/
and reported missed documentation in [DOC-META] Missing api documentation documentation-website#3614/guide/en/elasticsearch
were left in the plugin directory.Important notes:
https://opensearch.org/docs/latest/opensearch/index/
, which I assumed was base url so they were changed tohttps://opensearch.org/docs/
https://opensearch.org/docs/latest/im-plugin/index-templates/
, because PUT method of the same pattern was documented there so I assumed that after docs will be updated this will be the correct link.Issues Resolved
Fixes #3714
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr