Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the PR template to give an example linking issues with PR's #3730

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Updates the PR template to give an example linking issues with PR's #3730

merged 1 commit into from
Apr 3, 2023

Conversation

ashwin-pc
Copy link
Member

@ashwin-pc ashwin-pc commented Mar 30, 2023 •
edited
Loading

Description

Adds an example to show how issues can be linked to PR's so that PR's auto close issues that are linked. This requires the pr description to follow the format https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Issues Resolved

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ashwin-pc
updates PR template to hint at how to link issues to pull request
9f1db6b 
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@ashwin-pc ashwin-pc self-assigned this Mar 30, 2023
@ashwin-pc ashwin-pc requested a review from a team as a code owner March 30, 2023 02:19
@ashwin-pc ashwin-pc added backport 2.x Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Mar 30, 2023
@ashwin-pc ashwin-pc merged commit eb49f7f into opensearch-project:main Apr 3, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 3, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 3, 2023
@github-actions
updates PR template to hint at how to link issues to pull request (#3730
45b6839 
)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit eb49f7f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr pushed a commit that referenced this pull request Apr 4, 2023
@opensearch-trigger-bot @github-actions
updates PR template to hint at how to link issues to pull request (#3730
6c0d579 
) (#3774)

(cherry picked from commit eb49f7f)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vagimeli pushed a commit to vagimeli/OpenSearch-Dashboards that referenced this pull request Apr 4, 2023
@ashwin-pc @vagimeli
updates PR template to hint at how to link issues to pull request (op…
f0e762f 
…ensearch-project#3730)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: vagimeli <vagimeli@amazon.com>
sikhote pushed a commit to sikhote/OpenSearch-Dashboards that referenced this pull request Apr 24, 2023
@ashwin-pc @sikhote
updates PR template to hint at how to link issues to pull request (op…
e32383d 
…ensearch-project#3730)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

Assignees

@ashwin-pc ashwin-pc

Labels
backport 2.x devex Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashwin-pc @AMoo-Miki @kavilla @joshuarrrr