-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update logos site-wide with new OpenSearch branding #376
Conversation
Signed-off-by: Tommy Markley <markleyt@amazon.com>
✅ DCO Check Passed a9661a6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional tests are passing. I think overall looks good. It mimics how svgs are import EUI but can probably have some conditionality based on if the user is using darkmode or not
import React from 'react'; | ||
|
||
export function OpenSearchDashboardsLogoDarkMode() { | ||
return ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for draft purposes it's probably like this but we can probably be consistent with the other svgs were an svg file was created and accessed in the react component (without the helper functions):
addBasePath(
`/plugins/${PLUGIN_ID}/assets/opensearch_dashboards_${appId}_${
IS_DARK_THEME ? 'dark' : 'light'
}.svg`
)}
then we just make this opensearch_dashboards_logo.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you saying that this code would go in header_logo.tsx
? Where do the PLUGIN_ID
, appId
, and IS_DARK_THEME
props get passed in to the component from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And how do I test enabling/disabling dark mode?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to get these changes out for 1.0, I've added a follow-up task to the meta issue to address this feature for darkmode/default logos based on the theme: #372
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followup and improvements can be made but good first pass for replacing the heatmap.
Signed-off-by: Tommy Markley <markleyt@amazon.com>
Description
Brand Guidelines: https://opensearch.org/brand.html
Loading
Welcome
Header
Issues Resolved
#370
Check List