-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DEVELOPER_GUIDE.md #3764
Merged
ananzh
merged 2 commits into
opensearch-project:main
from
Nicksqain:add-trouble-solutions
Apr 7, 2023
Merged
Update DEVELOPER_GUIDE.md #3764
ananzh
merged 2 commits into
opensearch-project:main
from
Nicksqain:add-trouble-solutions
Apr 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com>
Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com>
ashwin-pc
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great additions to the dev guide, thanks!
ananzh
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you~~
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 7, 2023
* Update for devguide.md * Add changelog entry Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com> (cherry picked from commit 174756f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
ashwin-pc
pushed a commit
that referenced
this pull request
Apr 11, 2023
* Update DEVELOPER_GUIDE.md (#3764) * Update for devguide.md * Add changelog entry Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com> (cherry picked from commit 174756f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md * add changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <rmerqg@amazon.com>
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
* Update for devguide.md * Add changelog entry Signed-off-by: Alexei Karikov <karikov.alist.ru@gmail.com> Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added micro changes for DEVELOPER_GUIDE.md.
Issues Resolved
#3759 (Just a reference)
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr