-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Data Table rendering only in a small scrollable portion of the screen #3816
Fix: Data Table rendering only in a small scrollable portion of the screen #3816
Conversation
Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3816 +/- ##
==========================================
- Coverage 66.42% 66.41% -0.01%
==========================================
Files 3209 3209
Lines 61730 61730
Branches 9533 9533
==========================================
- Hits 41004 41000 -4
- Misses 18439 18442 +3
- Partials 2287 2288 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@curq Do you mind adding the repro steps for the issue? Before/after screenshot would be helpful too. |
@manasvinibs The reproduction steps are described in the issue that this PR is aimed to fix. I copied the steps from there, you can always refer to this issue #3737
Note that only 10 rows are shown, but the data table is actually scrollable with the mouse wheel to view 100 results within the small window: |
Thanks for the detailed steps. I'm able to repro the issue. Fix looks good to me. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3816-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 416eb508b3b22fe81231b726dcfce09e3aad9bfb
# Push it to GitHub
git push --set-upstream origin backport/backport-3816-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3816-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 416eb508b3b22fe81231b726dcfce09e3aad9bfb
# Push it to GitHub
git push --set-upstream origin backport/backport-3816-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
No need to backport - incorporated into #3397 |
…creen (opensearch-project#3816) * Fix table not adjusting height on initial page load Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> * formatting typo fix Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> * Update CHANGELOG.md Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> --------- Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> Signed-off-by: David Sinclair <david@sinclair.tech>
Description
Makes table component adjust its height on initial load. Before that it had fixed height on first load, resulting in table being rendered only in a small scrollable portion of the screen.
Issues Resolved
Fixes #3737
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr