Fix beta doc links, truncated help menu label #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… label isn't truncated Signed-off-by: Tommy Markley <markleyt@amazon.com>
|
✅ DCO Check Passed 5bfc5cb |
kavilla
reviewed
May 26, 2021
| @@ -126,16 +127,16 @@ export class DocLinksService { | |||
| introduction: `${OPENSEARCH_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/index-patterns.html`, | |||
| }, | |||
| addData: `${OPENSEARCH_WEBSITE_URL}guide/en/kibana/${DOC_LINK_VERSION}/connect-to-elasticsearch.html`, | |||
There was a problem hiding this comment.
do we want to replaced the "kibana" reference or just delete it to remove the reference or should we verify first if it's fine to leave the word kibana in?
There was a problem hiding this comment.
Yeah I can just remove the reference for now.
ananzh
previously approved these changes
May 26, 2021
Signed-off-by: Tommy Markley <markleyt@amazon.com>
|
✅ DCO Check Passed b0691c7 |
tmarkley
changed the title
kavilla
approved these changes
May 26, 2021
kavilla
pushed a commit
that referenced
this pull request
May 26, 2021
* Fix dashboards documentation and DQL links, expand help menu width so label isn't truncated Signed-off-by: Tommy Markley <markleyt@amazon.com> * Remove kibana references from doc links, fix aggregation links Signed-off-by: Tommy Markley <markleyt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tommy Markley markleyt@amazon.com
Description
This doesn't fix all links because not all pages exist in the beta docs site. This is a stopgap for the 1.0 release. The following links are addressed:
The help menu label for the "OpenSearch Dashboards documentation" option was truncated but that was fixed by expanding the width.
Issues Resolved
Addresses some of the links that need to be fixed for #335
Check List