Bump xml2js from 0.4.23 to 0.5.0 #3842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoguan1990
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu and
manasvinibs
as code owners
|
@joshuarrrr We still observed the Link checker failed for the two links in below. Can you please help check on that? |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3842 +/- ##
=======================================
Coverage 66.41% 66.42%
=======================================
Files 3209 3209
Lines 61733 61733
Branches 9534 9534
=======================================
+ Hits 41003 41004 +1
+ Misses 18442 18441 -1
Partials 2288 2288
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@aoguan1990 The link that's causing the link check failure is unreachable: http://roubenmeschian.com/rubo/?p=51 Can you open an issue to find where that link is referenced and remove it? |
Removed the unused url: http://roubenmeschian.com/rubo/?p=51. Thanks! @joshuarrrr |
joshuarrrr
reviewed
Apr 14, 2023
CHANGELOG.md
Outdated
| @@ -21,6 +21,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | |||
| - [CVE-2023-25166] Bump formula to 3.0.1 ([#3416](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3416)) | |||
| - [CVE-2023-25653] Bump node-jose to 2.2.0 ([#3445](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3445)) | |||
| - [CVE-2023-26486][cve-2023-26487] Bump vega from 5.22.1 to 5.23.0 ([#3533](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3533)) | |||
| - [CVE-2023-0842]Bump xml2js from 0.4.23 to 0.5.0 ([#3842](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3842)) | |||
There was a problem hiding this comment.
Suggested change
| - [CVE-2023-0842]Bump xml2js from 0.4.23 to 0.5.0 ([#3842](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3842)) | |
| - [CVE-2023-0842] Bump xml2js from 0.4.23 to 0.5.0 ([#3842](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/3842)) |
There was a problem hiding this comment.
Thanks for the comments, addressed as per comment.
src/plugins/discover/public/application/angular/doc_table/create_doc_table_react.tsx
Outdated
Show resolved
Hide resolved
AMoo-Miki
requested changes
Apr 14, 2023
Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>
Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>
Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>
Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>
Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>
Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>
Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>
Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>
Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>
Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>
Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>
aoguan1990
force-pushed
the
cve-fix-branch
branch
from
681c5af
to
87e4d8f
Compare
AMoo-Miki
previously approved these changes
Apr 14, 2023
Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com>
joshuarrrr
approved these changes
Apr 14, 2023
AMoo-Miki
approved these changes
Apr 15, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 15, 2023
* Create 1.3.8 release notes Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Remove unused tags Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Remove old changelog Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Fix typo Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Address comments Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Add PRs Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Remove unreleased PR Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Remove unreleased PR Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Bump xml2js from 0.4.22 to 0.5.0 Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Add change log for CVE Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Bump version for osd-test package Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Modify PR link for changelog Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Fix changelog and dependency package version Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Fix aws sdk version Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> --------- Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> (cherry picked from commit c755b49) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
abbyhu2000
pushed a commit
that referenced
this pull request
Apr 17, 2023
* Bump xml2js from 0.4.23 to 0.5.0 (#3842) * Create 1.3.8 release notes Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Remove unused tags Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Remove old changelog Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Fix typo Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Address comments Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Add PRs Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Remove unreleased PR Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Remove unreleased PR Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Bump xml2js from 0.4.22 to 0.5.0 Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Add change log for CVE Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Bump version for osd-test package Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Modify PR link for changelog Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Fix changelog and dependency package version Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Fix aws sdk version Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> --------- Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> (cherry picked from commit c755b49) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md * add changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <rmerqg@amazon.com>
sikhote
pushed a commit
to sikhote/OpenSearch-Dashboards
that referenced
this pull request
Apr 24, 2023
* Create 1.3.8 release notes Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Remove unused tags Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Remove old changelog Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Fix typo Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Address comments Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Add PRs Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Remove unreleased PR Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Remove unreleased PR Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Bump xml2js from 0.4.22 to 0.5.0 Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Add change log for CVE Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Bump version for osd-test package Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Modify PR link for changelog Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Fix changelog and dependency package version Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> * Fix aws sdk version Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> --------- Signed-off-by: Aozixuan Priscilla Guan <aoguan@amazon.com> Signed-off-by: David Sinclair <david@sinclair.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Description:
xml2jsfrom0.4.22to0.5.0to resolve CVE-2023-0842 in branch mainCheck List
yarn test:jestyarn test:jest_integrationyarn test:ftr