-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update aggregation config #3974
Conversation
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3974 +/- ##
==========================================
+ Coverage 66.38% 66.42% +0.03%
==========================================
Files 3229 3229
Lines 62068 62077 +9
Branches 9599 9601 +2
==========================================
+ Hits 41204 41234 +30
+ Misses 18556 18539 -17
+ Partials 2308 2304 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@raintygao some of the github workflows are failing. Let's make sure that all of them succeeds. |
@raintygao @navneet1v the ftr tests fail due to chromedrive incompatibility issue #3975. We also raised a PR which should unblock all the tests. |
@ananzh, @raintygao So the overall code looks good to me. I am approving the PR, as GHA failure is known issue. |
@ananzh Hi, when will my PR be in the review process from core team? Because the release status of our feature is associated with the merge status of PR. |
@raintygao Can you also add steps in the PR description on how we can validate the change? Also can you attach a GIF or a video for the UI changes? I cant quote about the exact date the change will go through, but we usually target to have the change reviewed in at most a week since its been assigned. After that it depends on how long it takes for the changes needed to be addressed. Thats why giving us screenshots and steps to validate helps because it makes the review process quicker. |
@ashwin-pc Done. |
Currently set the status of this pr to frozen . |
@raintygao why is this PR frozen? |
@raintygao I don't see this PR included in the platform upgrade list for 2.8.0: #3981, which means it's not planned for that release, although we'll still do our best to provide timely reviews. If you think it should be included, please add more information about the dependency and feature there. |
Thanks, due to the adjustment of external plugin and changes on ui, the technical solution may be changed. Will close PR first. |
Description
Add geo_shape type field support in geo_tile and geo_hash aggregation since OpenSearch has supported it.
Add a centroid switch in geo_tile aggregation to keep consistent with geo_hash aggregation, which can't be switched before and is true by default.
In centroid editor, set value false and switch disabled when field type is geo_shape because currently OpenSearch only supports geo_shape aggregation without centroid.
Target version
2.8
Validation steps
Issues Resolved
#3887 Resolved No.2.
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr