Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showing default tooltip on mark #4120

Conversation

amsiglan
Copy link
Collaborator

Description

Show custom tooltip for point in time annotation mark in vega visualization

Issues Resolved

Solves remaining part of #3317

Screenshot

image

Testing the changes

N/A

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Amardeepsingh Siglani <amardeep7194@gmail.com>
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Within the tooltip handler, we can process the item which will have the annotation type info. In this way, we can process any items that have this particular annotation type and render a custom value based on that (in our case, an aggregate breakdown of events by plugin resource type).

Current screenshot shows the default tooltip value, which is the x-axis value. This makes sense, since the event marks by default don't have encodings on the y-axis. This is the value we can override.

@ohltyler
Copy link
Member

I have a working follow up to show the values as expected. Currently in this commit: a38cc31

After this is merged will open a small PR to add this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants