Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Anywhere] Various bug fixes #4245

Merged
merged 3 commits into from
Jun 5, 2023
Merged

[Feature Anywhere] Various bug fixes #4245

merged 3 commits into from
Jun 5, 2023

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Jun 5, 2023 •
edited
Loading

Description

Various bug fixes:

  1. Hides 'view events' option on eligible charts, if there is no existing vislayers.
  2. Fixes text wrapping of plugin resource names in view events flyout by adding word-break styling. Also expands width from 150px -> 200px to increase likelihood of the names fitting on one line and not looking too squished/compact
  3. Adds external link to plugin resource names in view events flyout
  4. Cleans up default saved obj title in the saved obj management plugin to be augment-vis-<originPlugin>
  5. Disables/removes the 'View augment-vis' button in the saved obj details page in saved obj management plugin by updating the value in capabilitiesProvider.
  6. Updates the view events icon to inspect

Screenshots of fixes:
Updated name:
Screenshot 2023-06-05 at 3 27 27 PM

Correct text wrapping:
Screenshot 2023-06-05 at 2 43 45 PM

Removed 'View augment-vis' button:
Screenshot 2023-06-05 at 3 42 16 PM

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@ohltyler
Various bug fixes
63b6dde 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler changed the title Various bug fixes [Feature Anywhere] Various bug fixes Jun 5, 2023
ashwin-pc
ashwin-pc approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/plugins/vis_augmenter/server/saved_objects/augment_vis.ts Outdated Show resolved Hide resolved
src/plugins/vis_augmenter/public/view_events_flyout/actions/view_events_option_action.tsx Show resolved Hide resolved
ashwin-pc
ashwin-pc approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ohltyler
Change view events action icon to inspect
b61a6f6 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler
Remove lodash dep in getTitle()
1294725 
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
@ohltyler ohltyler merged commit b05c633 into opensearch-project:feature/feature-anywhere Jun 5, 2023
@ohltyler ohltyler deleted the bug-fix-1 branch June 5, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@lezzago lezzago lezzago approved these changes

Assignees
No one assigned
Labels
feature-anywhere seasoned-contributor v2.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ohltyler @lezzago @ashwin-pc