Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer] Clean out angular contents in Discover #4468

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jun 30, 2023

Issues Resolved

#4459

Blocked by
Step 1: #4432
Step 2: #4458

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #4468 (1368051) into feature/data-explorer (6e0a855) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@                    Coverage Diff                    @@
##           feature/data-explorer    #4468      +/-   ##
=========================================================
+ Coverage                  66.47%   66.57%   +0.10%     
=========================================================
  Files                       3280     3278       -2     
  Lines                      62700    62645      -55     
  Branches                    9766     9759       -7     
=========================================================
+ Hits                       41679    41708      +29     
+ Misses                     18648    18570      -78     
+ Partials                    2373     2367       -6     
Flag Coverage Δ
Linux 66.52% <100.00%> (?)
Windows 66.52% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...on/components/doc_viewer/doc_viewer_render_tab.tsx 80.00% <ø> (ø)
...ation/components/sidebar/discover_field_search.tsx 90.56% <ø> (+3.29%) ⬆️
...tion/components/sidebar/discover_index_pattern.tsx 87.50% <ø> (ø)
...mponents/skip_bottom_button/skip_bottom_button.tsx 100.00% <ø> (ø)
...blic/application/components/table/table_helper.tsx 100.00% <ø> (ø)
...plication/components/top_nav/open_search_panel.tsx 50.00% <ø> (ø)
...public/application/doc_views/doc_views_registry.ts 0.00% <ø> (ø)
.../discover/public/opensearch_dashboards_services.ts 58.82% <ø> (+1.68%) ⬆️
src/plugins/discover/public/plugin.ts 0.00% <ø> (-1.37%) ⬇️
...over/public/application/components/table/table.tsx 84.61% <100.00%> (ø)

... and 7 files with indirect coverage changes

@ashwin-pc ashwin-pc marked this pull request as draft July 5, 2023 20:59
@ananzh ananzh force-pushed the feature/data-explorer-clean branch from f5365b4 to 1cee327 Compare July 13, 2023 21:17
Issue Resolve
opensearch-project#4459

Signed-off-by: ananzh <ananzh@amazon.com>
@ananzh ananzh force-pushed the feature/data-explorer-clean branch from 1cee327 to 2b6e0e9 Compare July 13, 2023 22:00
@ananzh ananzh marked this pull request as ready for review July 18, 2023 16:54
@ashwin-pc ashwin-pc merged commit 6e87e28 into opensearch-project:feature/data-explorer Jul 20, 2023
21 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants