Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer] Mount views dynamically with services #4519

Merged

Conversation

ashwin-pc
Copy link
Member

Description

Data explorer views are mounted dynamically on switching so that services for each view can be intialized beforehand. core and plugin servoces are also passed down to the view. The pattern followed here is identical to the application mounting flow for OSD.

Issues Resolved

Part of #4227

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@ashwin-pc ashwin-pc added discover for discover reinvent de-angular de-angularize work data explorer Issues related to the Data Explorer project labels Jul 7, 2023
@ashwin-pc ashwin-pc changed the title Mount views dynamically with services [Data Explorer] Mount views dynamically with services Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #4519 (6de5b35) into feature/data-explorer (d4acb33) will decrease coverage by 0.04%.
The diff coverage is 31.42%.

@@                    Coverage Diff                    @@
##           feature/data-explorer    #4519      +/-   ##
=========================================================
- Coverage                  66.56%   66.52%   -0.04%     
=========================================================
  Files                       3278     3280       +2     
  Lines                      62654    62700      +46     
  Branches                    9760     9766       +6     
=========================================================
+ Hits                       41703    41713      +10     
- Misses                     18585    18619      +34     
- Partials                    2366     2368       +2     
Flag Coverage Δ
Linux 66.47% <31.42%> (-0.03%) ⬇️
Windows 66.47% <31.42%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/plugins/discover/public/plugin.ts 1.36% <0.00%> (-0.13%) ⬇️
.../data_explorer/public/components/app_container.tsx 33.33% <33.33%> (ø)
...lugins/data_explorer/public/components/sidebar.tsx 16.66% <100.00%> (ø)
...data_explorer/public/services/view_service/view.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@ananzh ananzh merged commit d4ce533 into opensearch-project:feature/data-explorer Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data explorer Issues related to the Data Explorer project de-angular de-angularize work discover for discover reinvent distinguished-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants