-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Explorer][Discover 2.0] Add initial DiscoverChart #4622
[Data Explorer][Discover 2.0] Add initial DiscoverChart #4622
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/data-explorer #4622 +/- ##
=========================================================
- Coverage 66.50% 66.32% -0.19%
=========================================================
Files 3289 3380 +91
Lines 62821 64661 +1840
Branches 9788 10303 +515
=========================================================
+ Hits 41782 42886 +1104
- Misses 18658 19239 +581
- Partials 2381 2536 +155
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e8dd409
to
7c6de40
Compare
@ananzh Should this be in draft mode? |
7c6de40
to
83d4c56
Compare
@joshuarrrr I rebase it based on @ashwin-pc #4678 Now I am able to see chart rendering correctly. The last commit is the chart one. |
4c5b489
to
fac176c
Compare
Issue Resolve opensearch-project#4571 Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: ananzh <ananzh@amazon.com>
23cc730
to
1321983
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! Looks good to me :)
Description
DiscoverChart contains HitsCounter, TimeChartHeader and Histogram in the previous discover_legacy.
Issues Resolved
#4571
Screenshot
Currently chart looks like this. x-axis doesn't show. The calculation of xInterval, xValues, domainStart, domainEnd, domainMin, domainMax, and xDomain in the render method in histogram.tsx determines the range and interval of the x-axis. Currently chartData prop is not providing the correct data because we are using the default size (500) but the time range is normal.
Next step is to continue implementation with state management to interact with top nav, including time range.
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr