Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer][Discover 2.0] Add initial DiscoverChart #4622

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Jul 26, 2023

Description

DiscoverChart contains HitsCounter, TimeChartHeader and Histogram in the previous discover_legacy.

Issues Resolved

#4571

Screenshot

Currently chart looks like this. x-axis doesn't show. The calculation of xInterval, xValues, domainStart, domainEnd, domainMin, domainMax, and xDomain in the render method in histogram.tsx determines the range and interval of the x-axis. Currently chartData prop is not providing the correct data because we are using the default size (500) but the time range is normal.

Screenshot 2023-07-26 at 08 46 23

Next step is to continue implementation with state management to interact with top nav, including time range.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #4622 (1321983) into feature/data-explorer (521f306) will decrease coverage by 0.19%.
Report is 2 commits behind head on feature/data-explorer.
The diff coverage is 57.58%.

@@                    Coverage Diff                    @@
##           feature/data-explorer    #4622      +/-   ##
=========================================================
- Coverage                  66.50%   66.32%   -0.19%     
=========================================================
  Files                       3289     3380      +91     
  Lines                      62821    64661    +1840     
  Branches                    9788    10303     +515     
=========================================================
+ Hits                       41782    42886    +1104     
- Misses                     18658    19239     +581     
- Partials                    2381     2536     +155     
Flag Coverage Δ
Linux_1 34.83% <8.96%> (?)
Linux_2 55.04% <84.33%> (?)
Linux_3 43.92% <43.13%> (?)
Linux_4 35.10% <14.56%> (?)
Windows ?
Windows_1 34.84% <8.96%> (?)
Windows_2 55.01% <84.33%> (?)
Windows_3 43.93% <43.13%> (?)
Windows_4 35.10% <14.56%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/osd-babel-preset/node_preset.js 100.00% <ø> (ø)
...osd-opensearch-archiver/src/lib/docs/test_stubs.ts 68.75% <ø> (ø)
...ch-archiver/src/lib/indices/create_index_stream.ts 69.76% <ø> (ø)
...ch-archiver/src/lib/indices/delete_index_stream.ts 50.00% <ø> (ø)
...ver/src/lib/indices/opensearch_dashboards_index.ts 0.00% <0.00%> (ø)
packages/osd-ui-shared-deps/theme.ts 41.66% <0.00%> (ø)
src/core/server/legacy/legacy_service.ts 75.38% <ø> (ø)
src/core/server/plugins/plugin_context.ts 45.45% <ø> (ø)
src/core/server/rendering/views/template.tsx 100.00% <ø> (ø)
...server/saved_objects/saved_objects_service.mock.ts 100.00% <ø> (ø)
... and 70 more

... and 214 files with indirect coverage changes

@ananzh ananzh force-pushed the feature/data-explorer-histogram branch 3 times, most recently from e8dd409 to 7c6de40 Compare July 26, 2023 21:58
@joshuarrrr
Copy link
Member

@ananzh Should this be in draft mode?

@ananzh ananzh force-pushed the feature/data-explorer-histogram branch from 7c6de40 to 83d4c56 Compare August 7, 2023 16:49
@ananzh
Copy link
Member Author

ananzh commented Aug 7, 2023

@ananzh Should this be in draft mode?

@joshuarrrr I rebase it based on @ashwin-pc #4678

Screenshot 2023-08-07 at 10 07 53

Now I am able to see chart rendering correctly. The last commit is the chart one.

@ananzh ananzh force-pushed the feature/data-explorer-histogram branch 3 times, most recently from 4c5b489 to fac176c Compare August 7, 2023 22:45
ananzh added 2 commits August 11, 2023 23:26
Signed-off-by: ananzh <ananzh@amazon.com>
@ananzh ananzh force-pushed the feature/data-explorer-histogram branch from 23cc730 to 1321983 Compare August 11, 2023 23:27
@ananzh ananzh requested a review from BSFishy as a code owner August 11, 2023 23:27
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Looks good to me :)

@ananzh ananzh merged commit 86768bc into opensearch-project:feature/data-explorer Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data explorer Issues related to the Data Explorer project de-angular de-angularize work discover for discover reinvent distinguished-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants