[Backport 2.x] [Console] Convert all non-autocomplete lib files to typescript #4623

opensearch-trigger-bot · 2023-07-26T16:25:12Z

Backport 5c2b22b from #4150.

* Convert non-autocomplete part to TS Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> * Update CHANGELOG.md Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> * refactor and improve typing Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> --------- Signed-off-by: Sirazh Gabdullin <sirazh.gabdullin@nu.edu.kz> (cherry picked from commit 5c2b22b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

codecov · 2023-07-26T16:44:55Z

Codecov Report

Merging #4623 (8975200) into 2.x (e25413e) will decrease coverage by 0.07%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##              2.x    #4623      +/-   ##
==========================================
- Coverage   66.12%   66.06%   -0.07%     
==========================================
  Files        3316     3316              
  Lines       63905    63899       -6     
  Branches    10088    10124      +36     
==========================================
- Hits        42260    42216      -44     
- Misses      19173    19270      +97     
+ Partials     2472     2413      -59

Flag	Coverage Δ
Linux_1	`34.76% <ø> (ø)`
Linux_2	`?`
Linux_3	`43.08% <88.88%> (-0.06%)`	⬇️
Linux_4	`35.09% <ø> (ø)`
Windows_1	`34.77% <ø> (ø)`
Windows_2	`55.03% <ø> (ø)`
Windows_3	`43.09% <88.88%> (-0.06%)`	⬇️
Windows_4	`35.09% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...lib/autocomplete/components/url_pattern_matcher.ts	`87.23% <ø> (ø)`
src/plugins/console/public/lib/osd/osd.ts	`62.50% <57.14%> (ø)`
.../console/public/lib/autocomplete/body_completer.ts	`84.25% <100.00%> (ø)`
...rc/plugins/console/public/lib/curl_parsing/curl.ts	`83.01% <100.00%> (ø)`
src/plugins/console/public/lib/osd/api.ts	`86.95% <100.00%> (ø)`

... and 21 files with indirect coverage changes

opensearch-trigger-bot bot requested a review from ananzh as a code owner July 26, 2023 16:25

opensearch-trigger-bot bot added autocut Skip the changelog verification check on backports OSCI Open Source Contributor Initiative repeat-contributor labels Jul 26, 2023

opensearch-trigger-bot bot requested a review from kavilla as a code owner July 26, 2023 16:25

opensearch-trigger-bot bot added the v2.10.0 label Jul 26, 2023

opensearch-trigger-bot bot requested review from seanneumann, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu, manasvinibs, ZilongX, Flyingliuhub and BSFishy as code owners July 26, 2023 16:25

joshuarrrr approved these changes Jul 26, 2023

View reviewed changes

abbyhu2000 approved these changes Jul 26, 2023

View reviewed changes

abbyhu2000 merged commit d3163cf into 2.x Jul 26, 2023
71 of 73 checks passed

github-actions bot deleted the backport/backport-4150-to-2.x branch July 26, 2023 18:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport 2.x] [Console] Convert all non-autocomplete lib files to typescript #4623

[Backport 2.x] [Console] Convert all non-autocomplete lib files to typescript #4623

opensearch-trigger-bot bot commented Jul 26, 2023

codecov bot commented Jul 26, 2023 •

edited

Loading

[Backport 2.x] [Console] Convert all non-autocomplete lib files to typescript #4623

[Backport 2.x] [Console] Convert all non-autocomplete lib files to typescript #4623

Conversation

opensearch-trigger-bot bot commented Jul 26, 2023

codecov bot commented Jul 26, 2023 • edited Loading

Codecov Report

codecov bot commented Jul 26, 2023 •

edited

Loading