-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Explorer] Persisted state and syncing, shared context, linking state to component + smaller changes #4652
[Data Explorer] Persisted state and syncing, shared context, linking state to component + smaller changes #4652
Conversation
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
…uting Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Codecov Report
@@ Coverage Diff @@
## feature/data-explorer #4652 +/- ##
=========================================================
- Coverage 66.50% 66.45% -0.06%
=========================================================
Files 3289 3291 +2
Lines 62821 62854 +33
Branches 9788 9792 +4
=========================================================
- Hits 41782 41769 -13
- Misses 18658 18707 +49
+ Partials 2381 2378 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
on: | ||
push: | ||
branches: ['**', '!backport/**'] | ||
branches: ['**', '!backport/**', '!feature/**'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When merging this into main
, we should watch out not to bring this over.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep :)
@@ -39,36 +40,63 @@ export interface DiscoverRootState extends RootState { | |||
discover: DiscoverState; | |||
} | |||
|
|||
const initialState = {} as DiscoverState; | |||
const initialState: DiscoverState = { | |||
columns: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Duplicate of #4678 |
Description
This PR might look big but its actually just 3 changes and a few cleanup tasks that simplify the app structure.
Changes:
_g
_a
_q
Other minor changes include:
docViewExpand
toexpandedHit
to make it clearer what it containssrc/plugins/discover/public/migrate_state.ts
and where ever its referenced.Note: The commit history has changes that have already been merged but the diff is accurate.
Issues Resolved
closes #4225
closes #4227
closes #4228
Screenshot
Ignore the layout issues, this will be fixed later
Screen.Recording.2023-08-01.at.4.15.59.AM.mov
Testing the changes
To test the state syncing:
To test the shared context, updating the columns should update the table and vice versa and only one network request should fire for an update in the netwprk tab to the
opensearch
routeCheck List
yarn test:jest
yarn test:jest_integration
yarn test:ftr