-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename kbn-i18n to osd-i18n (#37) #48
Conversation
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see new file of GuideLine.md. Was this removed purposefully ?
It's there for me. The file was renamed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
Signed-off-by: Bishoy Boktor <boktorbb@amazon.com>
Signed-off-by: Bishoy Boktor boktorbb@amazon.com