Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix BWC related CI failures by swapping dist url with snapshot url #4828

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

manasvinibs
Copy link
Member

Description

The BWC tests on 2.x are failing: https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/5895740470/job/16189125311.

BWC test files: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/.github/workflows/build_and_test_workflow.yml#L349 utilize the release artifact which is built by a configuration sent externally. If there are issues in the build release for OpenSearch then we will be impacted, where snapshot is built more frequently.

Issues Resolved

#4814

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #4828 (28d4261) into 2.x (dee93c9) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x    #4828   +/-   ##
=======================================
  Coverage   66.11%   66.12%           
=======================================
  Files        3315     3315           
  Lines       63909    63909           
  Branches    10126    10126           
=======================================
+ Hits        42256    42257    +1     
  Misses      19168    19168           
+ Partials     2485     2484    -1     
Flag Coverage Δ
Linux_1 34.77% <ø> (ø)
Linux_2 55.10% <ø> (ø)
Linux_3 43.02% <ø> (?)
Linux_4 35.08% <ø> (+<0.01%) ⬆️
Windows_1 34.79% <ø> (ø)
Windows_2 55.06% <ø> (ø)
Windows_3 43.03% <ø> (ø)
Windows_4 35.08% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@manasvinibs manasvinibs added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Aug 25, 2023
@manasvinibs manasvinibs marked this pull request as ready for review August 25, 2023 20:19
@AMoo-Miki
Copy link
Collaborator

Thanks Mana. While this PR is temporary, a future version will first attempt to use dist and if that fails, it will fallback to snapshots. If we dont have an issue tracking that, we should create one.

AMoo-Miki
AMoo-Miki previously approved these changes Aug 25, 2023
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
@manasvinibs
Copy link
Member Author

Thanks Mana. While this PR is temporary, a future version will first attempt to use dist and if that fails, it will fallback to snapshots. If we dont have an issue tracking that, we should create one.

Yes, we have this issue #4828

@joshuarrrr joshuarrrr merged commit d8f156f into opensearch-project:2.x Aug 28, 2023
52 checks passed
@kavilla
Copy link
Member

kavilla commented Aug 29, 2023

@manasvinibs should we forward port this?

@manasvinibs
Copy link
Member Author

@manasvinibs should we forward port this?

Good call! Yes, added the label.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 11, 2023
…rl (#4828)

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
(cherry picked from commit d8f156f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
manasvinibs pushed a commit that referenced this pull request Sep 11, 2023
…rl (#4828) (#4985)

(cherry picked from commit d8f156f)

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport main Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants