Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Explorer][Discover 2.0] Replace hide column and add move left/right #4838

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

ananzh
Copy link
Member

@ananzh ananzh commented Aug 28, 2023

Description

Screenshot 2023-08-28 at 09 25 53
  • customize hide column to delete column
  • add move left and move right
Screenshot 2023-08-28 at 09 26 18

Issues Resolved

#4822
#4823
#4824

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #4838 (fe13a28) into main (a239fc2) will decrease coverage by 0.07%.
The diff coverage is 75.72%.

❗ Current head fe13a28 differs from pull request most recent head cef0e08. Consider uploading reports for the commit cef0e08 to get more accurate results

@@            Coverage Diff             @@
##             main    #4838      +/-   ##
==========================================
- Coverage   66.38%   66.32%   -0.07%     
==========================================
  Files        3396     3390       -6     
  Lines       64865    64734     -131     
  Branches    10355    10309      -46     
==========================================
- Hits        43061    42934     -127     
+ Misses      19239    19232       -7     
- Partials     2565     2568       +3     
Flag Coverage Δ
Linux_1 34.90% <82.00%> (+0.05%) ⬆️
Linux_2 ?
Linux_3 ?
Linux_4 35.10% <82.00%> (+0.05%) ⬆️
Windows_1 34.92% <82.00%> (?)
Windows_2 55.10% <77.22%> (?)
Windows_3 43.98% <81.63%> (?)
Windows_4 35.10% <82.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/osd-babel-preset/node_preset.js 100.00% <ø> (ø)
...osd-opensearch-archiver/src/lib/docs/test_stubs.ts 68.75% <ø> (ø)
...ch-archiver/src/lib/indices/create_index_stream.ts 69.76% <ø> (ø)
...ch-archiver/src/lib/indices/delete_index_stream.ts 50.00% <ø> (ø)
...ver/src/lib/indices/opensearch_dashboards_index.ts 0.00% <0.00%> (ø)
packages/osd-pm/src/utils/package_json.ts 66.66% <ø> (ø)
packages/osd-ui-shared-deps/theme.ts 41.66% <0.00%> (ø)
src/core/public/chrome/chrome_service.mock.ts 100.00% <ø> (ø)
...c/core/public/chrome/ui/header/collapsible_nav.tsx 95.45% <ø> (ø)
src/core/public/chrome/ui/header/header.tsx 75.00% <ø> (ø)
... and 37 more

... and 48 files with indirect coverage changes

@ananzh ananzh changed the base branch from feature/data-explorer to main August 30, 2023 19:50
@ananzh ananzh force-pushed the feature/data-explorer-column branch 3 times, most recently from 570f849 to 69cd85f Compare August 30, 2023 19:55
…ight

* disable full screen mode
* customize hide column to delete column
* add move left and move right

Issue Resolve:
opensearch-project#4822
opensearch-project#4823
opensearch-project#4824

Signed-off-by: ananzh <ananzh@amazon.com>
@ananzh ananzh force-pushed the feature/data-explorer-column branch from 69cd85f to cef0e08 Compare August 30, 2023 20:04
@ashwin-pc ashwin-pc added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Aug 30, 2023
@ananzh ananzh merged commit 2738131 into opensearch-project:main Aug 30, 2023
42 of 46 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-4838-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 27381317e68264d08952ed5c0fa0e8a4f4b233a7
# Push it to GitHub
git push --set-upstream origin backport/backport-4838-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4838-to-2.x.

ashwin-pc pushed a commit to ashwin-pc/OpenSearch-Dashboards that referenced this pull request Aug 31, 2023
…ight (opensearch-project#4838)

* disable full screen mode
* customize hide column to delete column
* add move left and move right

Issue Resolve:
opensearch-project#4822
opensearch-project#4823
opensearch-project#4824

Signed-off-by: ananzh <ananzh@amazon.com>
(cherry picked from commit 2738131)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x data explorer Issues related to the Data Explorer project discover for discover reinvent distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants