-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Data Explorer][Discover 2.0] Append popout icon to oui link for doc viewer links #4855
[Data Explorer][Discover 2.0] Append popout icon to oui link for doc viewer links #4855
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4855 +/- ##
==========================================
- Coverage 66.43% 66.42% -0.02%
==========================================
Files 3396 3396
Lines 64865 64869 +4
Branches 10357 10358 +1
==========================================
- Hits 43096 43092 -4
- Misses 19209 19217 +8
Partials 2560 2560
Flags with carried forward coverage won't be shown. Click here to find out more.
|
6b43d72
to
d547d18
Compare
…viewer links Issue Resolve opensearch-project#4825 Signed-off-by: ananzh <ananzh@amazon.com>
d547d18
to
1d981e1
Compare
Signed-off-by: ananzh <ananzh@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-4855-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e9ad10ffb22f358e05d883f9ad8998e169e45fd0
# Push it to GitHub
git push --set-upstream origin backport/backport-4855-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
…viewer links (opensearch-project#4855) * [Data Explorer][Discover 2.0] Append popout icon to oui link for doc viewer links Issue Resolve opensearch-project#4825 Signed-off-by: ananzh <ananzh@amazon.com> * fix all failed ut Signed-off-by: ananzh <ananzh@amazon.com> --------- Signed-off-by: ananzh <ananzh@amazon.com> (cherry picked from commit e9ad10f)
Issues Resolved
#4825
Screenshot
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr