Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Manual Backport 2.x][@osd/pm] Automate multi-target bootstrap and build (#4650) #4860

Merged
merged 3 commits into from
Aug 31, 2023
Merged

[Manual Backport 2.x][@osd/pm] Automate multi-target bootstrap and build (#4650) #4860

merged 3 commits into from
Aug 31, 2023

Conversation

ashwin-pc
Copy link
Member

cherrypick 1674c97 from #4650

@AMoo-Miki @ashwin-pc
[@osd/pm] Automate multi-target bootstrap and build (opensearch-proje…
fdf902c 
…ct#4650)

Also:
* build @osd/std for multiple targets
* convert @osd/i18n and @osd/ace from custom build scripts to targeted build process
* have @osd/optimizer ignore already built artifacts

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 1674c97)
@codecov
Copy link

codecov bot commented Aug 30, 2023 •
edited
Loading

Codecov Report

Merging #4860 (ecbd6dd) into 2.x (12eade7) will decrease coverage by 0.01%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##              2.x    #4860      +/-   ##
==========================================
- Coverage   66.32%   66.32%   -0.01%     
==========================================
  Files        3321     3322       +1     
  Lines       63897    63911      +14     
  Branches    10112    10119       +7     
==========================================
+ Hits        42382    42386       +4     
- Misses      19028    19045      +17     
+ Partials     2487     2480       -7
Flag Coverage Δ
Linux_1 34.86% <100.00%> (+<0.01%) ⬆️
Linux_2 55.18% <58.33%> (+0.03%) ⬆️
Linux_3 43.38% <100.00%> (-0.13%) ⬇️
Linux_4 35.08% <100.00%> (-0.05%) ⬇️
Windows_1 34.87% <100.00%> (+<0.01%) ⬆️
Windows_2 55.15% <58.33%> (+0.03%) ⬆️
Windows_3 43.39% <100.00%> (-0.13%) ⬇️
Windows_4 35.08% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/osd-pm/src/utils/package_json.ts 66.66% <ø> (ø)
packages/osd-pm/src/utils/targeted_build.ts 16.66% <16.66%> (ø)
packages/osd-pm/src/utils/project.ts 66.26% <100.00%> (+4.62%) ⬆️
packages/osd-std/src/index.ts 100.00% <100.00%> (ø)

... and 19 files with indirect coverage changes

@ashwin-pc ashwin-pc added the autocut Skip the changelog verification check on backports label Aug 30, 2023
@joshuarrrr
Copy link
Member

@ashwin-pc I think you'll need to update snapshots for this, as there are changes due to #4796 already being merged.

@ashwin-pc @AMoo-Miki
Apply suggestions from code review
ecbd6dd 
Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Ashwin P Chandran <ashwinpc1993@gmail.com>
@ashwin-pc
Copy link
Member Author

Cypress tests will pass once the Data explorer changes are merged to 2.x

@AMoo-Miki AMoo-Miki merged commit 6542257 into opensearch-project:2.x Aug 31, 2023
53 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AMoo-Miki AMoo-Miki AMoo-Miki approved these changes

@ZilongX ZilongX ZilongX approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports v2.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashwin-pc @joshuarrrr @AMoo-Miki @ZilongX