Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WS-2021-0638][Security] Alias and bump mocha to v10.1.0 #4874

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Aug 31, 2023

Cherry-pick 9377fbb from #2711 and:

  • Update to mocha@^10.1.0, aliased as mocha-next
  • Update to eslint-plugin-mocha@^10.1.0, aliased as eslint-plugin-mocha-next
  • Update to @types/mocha@^10.0.1, aliased as @types/mocha-next

PS, aliasing prevents it from being a breaking change.

Issues Resolved

Fixes #2269

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Cherry-pick 9377fbb from opensearch-project#2711 and:
* Update to `mocha@^10.1.0`, aliased as `mocha-next`
* Update to `eslint-plugin-mocha@^10.1.0`, aliased as `eslint-plugin-mocha-next`
* Update to `@types/mocha@^10.0.1`, aliased as `@types/mocha-next`

Signed-off-by: Miki <miki@amazon.com>
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #4874 (49be141) into 2.x (921263a) will decrease coverage by 0.02%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##              2.x    #4874      +/-   ##
==========================================
- Coverage   66.46%   66.44%   -0.02%     
==========================================
  Files        3396     3396              
  Lines       64847    64847              
  Branches    10356    10356              
==========================================
- Hits        43100    43088      -12     
- Misses      19190    19202      +12     
  Partials     2557     2557              
Flag Coverage Δ
Linux_1 34.91% <80.00%> (ø)
Linux_2 55.18% <0.00%> (ø)
Linux_3 44.20% <ø> (-0.01%) ⬇️
Linux_4 35.08% <ø> (ø)
Windows_1 34.93% <80.00%> (-0.05%) ⬇️
Windows_2 55.15% <0.00%> (ø)
Windows_3 44.20% <ø> (ø)
Windows_4 35.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/dev/mocha/run_mocha_cli.js 91.30% <50.00%> (ø)
...ctional_test_runner/lib/mocha/reporter/reporter.js 11.11% <100.00%> (ø)
...rc/functional_test_runner/lib/mocha/setup_mocha.js 35.29% <100.00%> (ø)
src/dev/mocha/auto_junit_reporter.js 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@manasvinibs manasvinibs merged commit 993ebc0 into opensearch-project:2.x Sep 1, 2023
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants