Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use themes' definitions to render the initial view. #4936

Merged

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Sep 5, 2023

Use themes' definitions to render the initial view. This impacts the loading screen font and colors.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…loading screen font and colors.

Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki AMoo-Miki changed the title Use theme's definition to render the initial view Use themes' definitions to render the initial view. Sep 5, 2023
@joshuarrrr
Copy link
Member

@AMoo-Miki Can you add before/after screenshots or recordings? This is intended to just be a refactor, right?

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #4936 (f28c46a) into main (cf07424) will decrease coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #4936      +/-   ##
==========================================
- Coverage   66.39%   66.39%   -0.01%     
==========================================
  Files        3397     3398       +1     
  Lines       64807    64815       +8     
  Branches    10361    10362       +1     
==========================================
+ Hits        43029    43033       +4     
- Misses      19218    19221       +3     
- Partials     2560     2561       +1     
Flag Coverage Δ
Linux_1 34.84% <ø> (ø)
Linux_2 55.16% <83.33%> (+<0.01%) ⬆️
Linux_3 44.23% <33.33%> (-0.01%) ⬇️
Linux_4 34.92% <33.33%> (+<0.01%) ⬆️
Windows_1 34.86% <ø> (ø)
Windows_2 55.12% <83.33%> (+<0.01%) ⬆️
Windows_3 44.24% <33.33%> (-0.01%) ⬇️
Windows_4 34.92% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/osd-ui-shared-deps/theme.ts 41.66% <ø> (ø)
src/core/server/rendering/views/fonts.tsx 100.00% <ø> (ø)
src/core/server/rendering/views/template.tsx 100.00% <ø> (ø)
src/core/server/rendering/views/theme.ts 77.77% <77.77%> (ø)
src/core/server/rendering/views/styles.tsx 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

Copy link
Member

@joshuarrrr joshuarrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changed LGTM

@joshuarrrr joshuarrrr merged commit 5eedbb5 into opensearch-project:main Sep 5, 2023
62 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2023
…loading screen font and colors. (#4936)

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 5eedbb5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
joshuarrrr pushed a commit that referenced this pull request Sep 6, 2023
…loading screen font and colors. (#4936) (#4939)

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 5eedbb5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants