-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use themes' definitions to render the initial view. #4936
Use themes' definitions to render the initial view. #4936
Conversation
…loading screen font and colors. Signed-off-by: Miki <miki@amazon.com>
89fac80
to
f28c46a
Compare
@AMoo-Miki Can you add before/after screenshots or recordings? This is intended to just be a refactor, right? |
Codecov Report
@@ Coverage Diff @@
## main #4936 +/- ##
==========================================
- Coverage 66.39% 66.39% -0.01%
==========================================
Files 3397 3398 +1
Lines 64807 64815 +8
Branches 10361 10362 +1
==========================================
+ Hits 43029 43033 +4
- Misses 19218 19221 +3
- Partials 2560 2561 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code changed LGTM
…loading screen font and colors. (#4936) (#4939) Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit 5eedbb5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Use themes' definitions to render the initial view. This impacts the loading screen font and colors.
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr