Fix (discover): Fix dismiss callout and next styling #4938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fix `onDismiss` prop of callout 2. Put callout in panel for better alignment in discover 3. Add `subdued` to combobox panel 4. Use `primary`-derived color for field titles in discover (and lint-ignore) Signed-off-by: Josh Romero <rmerqg@amazon.com>
joshuarrrr
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
Signed-off-by: Josh Romero <rmerqg@amazon.com>
kavilla
previously approved these changes
Sep 5, 2023
|
Backporting for 2.10 right? |
abbyhu2000
previously approved these changes
Sep 5, 2023
fix conflict
ashwin-pc
reviewed
Sep 5, 2023
| @@ -49,11 +49,27 @@ export default function DiscoverCanvas({ setHeaderActionMenu, history }: ViewPro | |||
| if (isCallOutVisible) { | |||
| callOut = ( | |||
| <EuiFlexItem grow={false}> | |||
| <EuiPanel hasBorder={false} hasShadow={false} color="transparent" paddingSize="s"> | |||
There was a problem hiding this comment.
Why do we have 2 callouts here?
There was a problem hiding this comment.
that was a merge conflict - should be fixed
There was a problem hiding this comment.
oh, somehow managed to not commit - let me try again.
There was a problem hiding this comment.
ha, OK, yeah, this should be fixed - but doublecheck my resolution here.
ashwin-pc
previously approved these changes
Sep 5, 2023
ashwin-pc
added
discover
abbyhu2000
previously approved these changes
Sep 5, 2023
Codecov Report
@@ Coverage Diff @@
## main #4938 +/- ##
=======================================
Coverage 66.39% 66.39%
=======================================
Files 3398 3398
Lines 64815 64815
Branches 10362 10362
=======================================
Hits 43033 43033
+ Misses 19221 19198 -23
- Partials 2561 2584 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Josh Romero <rmerqg@amazon.com>
joshuarrrr
dismissed stale reviews from abbyhu2000 and ashwin-pc
via
47b0b26
|
@joshuarrrr looks like it just needs a snapshot updating |
Signed-off-by: Josh Romero <rmerqg@amazon.com>
|
Will set DCO to pass, it's being squashed anyways. |
kavilla
approved these changes
Sep 6, 2023
ashwin-pc
approved these changes
Sep 6, 2023
abbyhu2000
approved these changes
Sep 6, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Fix (discover): Fix dismiss callout and next styling 1. Fix `onDismiss` prop of callout 2. Put callout in panel for better alignment in discover 3. Add `subdued` to combobox panel 4. Use `primary`-derived color for field titles in discover (and lint-ignore) Signed-off-by: Josh Romero <rmerqg@amazon.com> * Update index.tsx fix conflict * fix linting indentation Signed-off-by: Josh Romero <rmerqg@amazon.com> * update snapshot Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit d3388c5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr
pushed a commit
that referenced
this pull request
Sep 7, 2023
* Fix (discover): Fix dismiss callout and next styling 1. Fix `onDismiss` prop of callout 2. Put callout in panel for better alignment in discover 3. Add `subdued` to combobox panel 4. Use `primary`-derived color for field titles in discover (and lint-ignore) * Update index.tsx fix conflict * fix linting indentation * update snapshot --------- (cherry picked from commit d3388c5) Signed-off-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes some small styling issues identified by @KrooshalUX and @kgcreative when reviewing
nextthemingonDismissprop of calloutsubduedto combobox panelprimary-derived color for field titles in discover (and lint-ignore)Note - I tried to fix the histogram rect highlight color in
nextdark mode, but can't figure out the problem. I got as far as confirming that bothdiscoverandlegacy_discoverpass the same styling props, but somehow it's not applied the same in each case.I also notices some other minor fit and finish issues in the video:
Issues Resolved
Screenshot
Screen.Recording.2023-09-05.at.3.48.24.PM.mov
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr