Bump agentkeepalive to v4.5.0
#4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AMoo-Miki
requested review from
ananzh,
kavilla,
seanneumann,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy and
curq
as code owners
AMoo-Miki
force-pushed
the
bump-agentkeepalive-450
branch
from
b2327d2
to
fe8289b
Compare
Codecov Report
@@ Coverage Diff @@
## main #4949 +/- ##
=======================================
Coverage 66.77% 66.77%
=======================================
Files 3278 3278
Lines 62981 62981
Branches 10027 10027
=======================================
Hits 42055 42055
Misses 18461 18461
Partials 2465 2465
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
should we consider this a breaking change? |
… `https://ip` in `opensearch.hosts` The `elasticsearch` client uses a flaws version that incorrectly sets `servername` on a `tls` connection using IPs. Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki
force-pushed
the
bump-agentkeepalive-450
branch
from
fe8289b
to
4f6cbbd
Compare
The functionality has been broken for as long as |
ananzh
previously approved these changes
Sep 12, 2023
|
@AMoo-Miki should we also backport to 1.3? |
1.3 receiving only security patches and bug fixes, I don't think this needs to go there. |
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
|
@AMoo-Miki I think the link checker failure is spurious, but could you check? |
kavilla
approved these changes
Sep 28, 2023
|
whitesource issue tracked separately in #5178 |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-4949-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d017c5caddd732fafc1c2a2fc8ca4be99fac7c0b
# Push it to GitHub
git push --set-upstream origin backport/backport-4949-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
joshuarrrr
pushed a commit
to joshuarrrr/OpenSearch-Dashboards
that referenced
this pull request
Oct 3, 2023
… `https://ip` in `opensearch.hosts` (opensearch-project#4949) The `elasticsearch` client uses a flaws version that incorrectly sets `servername` on a `tls` connection using IPs. Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit d017c5c)
ananzh
pushed a commit
that referenced
this pull request
Oct 3, 2023
… `https://ip` in `opensearch.hosts` (#4949) (#5180) The `elasticsearch` client uses a flaws version that incorrectly sets `servername` on a `tls` connection using IPs. Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit d017c5c) Co-authored-by: Miki <miki@amazon.com>
Leo7Deng
pushed a commit
to Leo7Deng/OpenSearch-Dashboards
that referenced
this pull request
Oct 4, 2023
… `https://ip` in `opensearch.hosts` (opensearch-project#4949) The `elasticsearch` client uses a flaws version that incorrectly sets `servername` on a `tls` connection using IPs. Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Leo Deng <leo7deng@gmail.com>
willie-hung
pushed a commit
to willie-hung/OpenSearch-Dashboards
that referenced
this pull request
Oct 5, 2023
… `https://ip` in `opensearch.hosts` (opensearch-project#4949) The `elasticsearch` client uses a flaws version that incorrectly sets `servername` on a `tls` connection using IPs. Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Josh Romero <rmerqg@amazon.com> Co-authored-by: Josh Romero <rmerqg@amazon.com> Signed-off-by: Willie Hung <willie880201044@gmail.com>
|
Is the deprecation warning expected to be permanent? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump
agentkeepaliveto v4.5.0 to solve a problem preventing the usehttps://ipinopensearch.hosts.The
elasticsearchclient uses a flawed version that incorrectly setsservernameon atlsconnection using IPs.Expect a deprecation warning while bootstrapping:
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr