[Backport 2.10] Correct the generated path for downloading plugins by their names on Windows #4972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…Windows (#4953) * Correct the generated path for downloading plugins by their names on Windows Signed-off-by: Miki <miki@amazon.com> * Update snapshot for unit test Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Add link for integration to lycheeexlude Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 43fe5d5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla and
seanneumann
as code owners
opensearch-trigger-bot
bot
added
the
autocut
opensearch-trigger-bot
bot
requested a review
from AMoo-Miki
as a code owner
opensearch-trigger-bot
bot
requested review from
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
kavilla
approved these changes
Sep 7, 2023
Codecov Report
@@ Coverage Diff @@
## 2.10 #4972 +/- ##
=======================================
Coverage 66.44% 66.44%
=======================================
Files 3399 3399
Lines 64881 64881
Branches 10360 10360
=======================================
+ Hits 43107 43111 +4
- Misses 19215 19292 +77
+ Partials 2559 2478 -81
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 21 files with indirect coverage changes 📢 Have feedback on the report? Share it here. |
joshuarrrr
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 43fe5d5 from #4953.