Basic working version of OSD without angular

[ashwin-pc]

Description

Initial commit to remove the angular dependency from Dashboards. The PR has the following changes:

1. Removes the angularjs npm dependency and any other angular related dependency
2. Removes the discover_legacy plugin. Has additional changes that are needed to ensure that the removal is clean and also needs to verify that some of the features that still relied on the legacy plugin like saved search embeddable are added
3. Removes i18n's angular folder. Again need to verify that this does not break anything. From my testing it does not but need to also verify what API's were broken because of this
4. removes the angular exports from the osd-ui-shared-deps folder. Again need to investigate the implications of this. Did not see any so far.
5. Deleted the angular folder from opensearch_dashboards_legacy plugin. Need to verify the implications of this. None so far
6. Commented out the angular sanitize import. Does not seem to affect the rendering of visualizations including map visualizations. There is however a TODO here that implies that not adding it breaks visualizations, so this needs to be verified too.

Overall these changes do not seem to affect any of the Dashboards functionality from a very basic walkthrough of the app, but that needs to be backed up by some of the investigations i've called out above.

While the diff is huge, most of that is from just deleting the discover legacy plugin. and other angular specific folders within plugins. Once you skip past that, the rest of the changes should be easily viewable.

Issues Resolved

Screenshot

Testing the changes

Startup the application and make sure that all functionality works as expected.

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

Merging #4982 (2376046) into feature/deangular (0709333) will increase coverage by 0.09%.
The diff coverage is 0.00%.

@@                  Coverage Diff                  @@
##           feature/deangular    #4982      +/-   ##
=====================================================
+ Coverage              66.47%   66.56%   +0.09%     
=====================================================
  Files                   3399     3279     -120     
  Lines                  64915    63024    -1891     
  Branches               10387    10016     -371     
=====================================================
- Hits                   43153    41955    -1198     
+ Misses                 19204    18608     -596     
+ Partials                2558     2461      -97     

Flag	Coverage Δ
Linux_1	35.16% <0.00%> (+0.36%)	⬆️
Linux_2	55.23% <ø> (-0.08%)	⬇️
Linux_3	43.37% <ø> (-1.09%)	⬇️
Linux_4	35.43% <ø> (+0.54%)	⬆️
Windows_1	35.18% <0.00%> (+0.32%)	⬆️
Windows_2	55.20% <ø> (-0.08%)	⬇️
Windows_3	43.38% <ø> (-1.09%)	⬇️
Windows_4	35.43% <ø> (+0.54%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
packages/osd-ui-shared-deps/index.js	100.00% <ø> (ø)
src/plugins/dashboard/public/plugin.tsx	0.00% <ø> (ø)
src/plugins/discover/common/index.ts	100.00% <ø> (ø)
src/plugins/discover/public/index.ts	0.00% <ø> (ø)
src/plugins/discover/public/plugin.ts	0.00% <0.00%> (ø)
...ugins/opensearch_dashboards_legacy/public/index.ts	50.00% <ø> (ø)

... and 12 files with indirect coverage changes

[junqiu-lei]

Thanks @ashwin-pc, I just tested on my local that no issue found on Region map and Coordinate map visualizations.

[ananzh]

So nice to see angular retirement!! I am okay with all the deletions only one minor comment. I pull down this PR and I think there are couple of things that we could continuously clean/remove:

Clean/Modify documents

Some docs still have angular context. I don't think we need to fix all of them in this PR or 2.11. But we should open issues to document each one of them. Some important ones are:

• packages/osd-i18n/GUIDELINE.md
• packages/osd-i18n/README.md
• src/dev/i18n/README.md
• DEVELOPER_GUIDE.md

I18n

• Clean src/dev/i18n/extract_default_translations.test.js and update data in src/dev/i18n/__fixtures__/extract_default_translations(replace html to jsx). This test and related data are still angular. We need open issue and fix it before 2.11. Not a blocker for this PR.
• Remove packages/osd-i18n/angular/package.json.

opensearch_dashboards_legacy

I think there are couple of things we could do for this package. We also want to evaluate the impacts. If we need to research more on these legacy functions and this package, I am okay with a separate PR.

• Remove src/plugins/opensearch_dashboards_legacy/public/paginate. This paginate is only for angular. Specifically, it's defining two AngularJS directives: PaginateDirectiveProvider and PaginateControlsDirectiveProvider.
  The PaginateDirectiveProvider seems to provide pagination functionality for a list, while PaginateControlsDirectiveProvider provides the UI for controlling the pagination. We don't need them any more and we also should clean paginate from src/plugins/opensearch_dashboards_legacy/public/index.ts.

• Clean out src/plugins/opensearch_dashboards_legacy/public/notify:
  Remove src/plugins/opensearch_dashboards_legacy/public/notify/lib/format_angular_http_error.ts
  Remove src/plugins/opensearch_dashboards_legacy/public/notify/lib/add_fatal_error.ts
  Clean src/plugins/opensearch_dashboards_legacy/public/notify/lib/index.ts

• Clean out src/plugins/opensearch_dashboards_legacy/public/utils
  Remove src/plugins/opensearch_dashboards_legacy/public/utils/system_api.ts
  Remove src/plugins/opensearch_dashboards_legacy/public/utils/register_listen_event_listener.js
  Remove src/plugins/opensearch_dashboards_legacy/public/utils/private.js Remove src/plugins/opensearch_dashboards_legacy/public/utils/private.d.ts
  Remove src/plugins/opensearch_dashboards_legacy/public/utils/osd_accessible_click.js

Test

• Remove/Replace test/plugin_functional/plugins/doc_views_plugin/public/plugin.tsx and test/plugin_functional/test_suites/doc_views/doc_views.ts. Not a blocker but should open an issue.

Data plugin

• Update toAngularJSON(filter.input.query)) to toAngularJSON(filter.input.query)) in src/plugins/data/common/search/aggs/buckets/filters.ts. Then remove src/plugins/data/common/search/aggs/utils/to_angular_json.ts and clean src/plugins/data/common/search/aggs/utils/index.ts.

[ananzh]

Why comment it out? Should we just remove this line? Also remove TODO?

[ananzh]

@junqiu-lei , since you found no issue on Region map and Coordinate map visualizations, could you confirm that this import is no needed and we could remove this completely and also TODO?

[junqiu-lei]

+1. From my local test, I think we can remove the import and TODO.

[zashary]

How do we determine whether short urls are allowed?

[ashwin-pc]

Sorry @zashary but what do you mean by that? I didnt understand the question.

The change that you highlighted here was added for type safety. While discover should always have a boolean value for createShortUrl, The capability service as it stands today is not strictly typed for that and this property can be left undefined if initialized differently. Instead of refactoring the whole capability service, i just corrected the type for the capability service so that every use of the service can handle for an unexpected undefined if that happens.

[ananzh]

We will create issues and follow up PRs addressing left angular cleaning.